Decaffeinate and get ready for PulsarNext #10
Conversation
…e and 4 other files
…and clean up decaffeination of source.
|
CI passes! All that's left is for me to update the dependencies to the NPM-published (and |
|
OK, updated the dependencies and the Linux CI job is happy. I assume the macOS job will eventually agree. Out of draft and ready for review! |
There was a problem hiding this comment.
I've gone ahead and reviewed all of your manual changes and the other changes roughly.
Things largely look great! I think there's still a couple chances at clean up here, like removing what seems to be some leftover .coffee files, and removing any dependencies and scripts used for building docs. But otherwise we should be good. So I'm adding an approval here to indicate we are good to go, or future approving for my suggestions having been made.
One small note I might make, is in the future when doing decaf work on so many files, we may want to reference back to our original decaf guide as otherwise it's pretty hard to review it. But since we have passing tests and you've tested this yourself and have such a great track record with things like this I'm not too worried about any issues.
| "main": "./src/text-buffer", | ||
| "scripts": { | ||
| "prepublish": "npm run clean && npm run compile && npm run lint && npm run docs", | ||
| "prepublish": "npm run clean", |
There was a problem hiding this comment.
We very likely could remove all these steps and the Joanna dep from this repo, since we no longer utilize the local api.json to construct our API docs, everything would be handled over on the documentation repository.
|
OK, removed |
3 participants
Keeping this as a draft until it includes proper bumps for
superstringandpathhwatcher, but I'm pretty excited about the decaffeination. Most of it was spearheaded by @mauricioszabo, as you can see in the commit history… but I decided to go further and decaf the spec suite as well. Miraculously, they all pass.Anyway, look over this if you like, but feel free to wait until it's out of draft. Putting it up here so I don't forget about it and to ensure that CI agrees with my assessment of the test suite.