Skip to content

Conversation

@CamSoper
Copy link
Contributor

Aliases Neo documentation pages (instead of S3 redirects)

@pulumi-bot
Copy link
Collaborator

@claude
Copy link
Contributor

claude bot commented Sep 22, 2025

Pull Request Review

This PR successfully converts S3 redirects to Hugo aliases for Neo documentation pages. The changes are clean and follow repository conventions.

✅ Positive Aspects

  • Correct approach: Using Hugo aliases instead of S3 redirects is the proper way to handle URL redirects in this Hugo-based site
  • Complete migration: All redirect rules from neo-redirects.txt have been properly converted to aliases in the corresponding pages
  • Proper formatting: All aliases follow the correct Hugo front matter syntax
  • File integrity: All modified files properly end with newlines as required by AGENTS.md
  • Clean removal: The scripts/redirects/neo-redirects.txt file is appropriately deleted since it's no longer needed

📋 Technical Validation

  • All 5 Neo documentation pages have been updated with appropriate aliases
  • The aliases correctly map the old /docs/iac/neo/ and /docs/neo/ paths to the new /docs/pulumi-cloud/neo/ structure
  • Front matter syntax is consistent across all files
  • No style guide violations detected

✅ Recommendation

APPROVE - This is a straightforward and necessary change that properly implements URL redirects using Hugo's built-in alias functionality rather than external S3 redirects.

@CamSoper CamSoper enabled auto-merge (squash) September 22, 2025 21:11
Copy link
Member

@jkodroff jkodroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments.

meta_image: /images/docs/meta-images/docs-meta.png
aliases:
- /docs/iac/neo/
- /docs/neo/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is actually necessary unless there's something I missed, but it does no harm.

aliases:
- /docs/iac/neo/
- /docs/neo/
menu:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really feels like something should need to edited here in order to make it a child of the Pulumi Cloud menu, but the preview is clearly correct.

@CamSoper CamSoper merged commit 092a9e0 into master Sep 22, 2025
10 of 11 checks passed
@CamSoper CamSoper deleted the fix-neo-redirects branch September 22, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants