Skip to content

Conversation

@seanyeh
Copy link
Contributor

@seanyeh seanyeh commented Sep 23, 2025

Proposed changes

Make oidc gcp docs clearer - it should be project number, not id

Unreleased product version (optional)

Related issues (optional)

@claude
Copy link
Contributor

claude bot commented Sep 23, 2025

Review Feedback

✅ Accurate technical change: The change from project-id to project-number is correct. The gcp-login provider requires the numerical project number (e.g., 123456789), not the string project ID (e.g., my-project-name), as confirmed in the official provider documentation.

⚠️ Inconsistency to address:

Line 61 still references "project ID" but should be updated for consistency:

Make a note of the project ID, workload identity pool ID, provider ID, and service account email address from the previous steps.

Should be changed to:

Make a note of the project number, workload identity pool ID, provider ID, and service account email address from the previous steps.

✅ Style compliance: The changes follow the style guide appropriately.

Recommendation: Please update line 61 to maintain consistency throughout the document.

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@seanyeh seanyeh merged commit 41dbbf4 into master Sep 23, 2025
11 checks passed
@seanyeh seanyeh deleted the syeh/improve-gcp-oidc-docs branch September 23, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants