Add CDN Log Delivery source

[sicarul]

I tried using Pulumi import but it'd not get the properties and then it'd fail - Using lookup pulumi is able to reference the resource anyway without bringing it into state.

[claude]

PR Review: Add CDN Log Delivery source

Issues Found

1. Capitalization inconsistency (line 803)
The comment uses "Cdn" which should be "CDN" (an acronym for Content Delivery Network). According to the style guide, acronyms should be fully capitalized.

2. Incomplete migration
The change switches from creating a new LogDeliverySource to referencing an existing one via .get(), but there are concerns:

• The hardcoded ID "CreatedByCloudFront-E3PRSXO1BZJEEY" appears to be environment-specific and may not work across different deployments
• The resource name "cloudfront_logs" doesn't follow the naming pattern used elsewhere in the file (which uses kebab-case like "cdn-log-delivery-destination")
• Line 824 references cdnLogDeliverySource.name, but the .get() method's second parameter ("cloudfront_logs") is the resource name in Pulumi state, not the actual AWS resource name. This may cause runtime issues if the AWS resource has a different name.

3. Code verification needed
Before merging, verify that:

• The cdnLogDeliverySource.name property returns the correct AWS resource name expected by the cdnLogDelivery resource on line 824
• This configuration has been tested in the target environment
• The hardcoded ID works in production

Suggested Changes

Line 803:

-// The Cdn Log Delivery Source was configured outside of Pulumi
+// The CDN Log Delivery Source was configured outside of Pulumi

Lines 806-809:
Consider adding a comment explaining where these values come from:

// Reference the CloudFront-created log delivery source
// ID: CreatedByCloudFront-E3PRSXO1BZJEEY (created automatically by CloudFront)
// Resource name in Pulumi state: cloudfront_logs
const cdnLogDeliverySource = aws.cloudwatch.LogDeliverySource.get(
    "CreatedByCloudFront-E3PRSXO1BZJEEY",
    "cloudfront_logs"
);

Questions

1. Have you verified that cdnLogDeliverySource.name returns the correct AWS resource name for use in the LogDelivery resource?
2. Is the hardcoded ID "CreatedByCloudFront-E3PRSXO1BZJEEY" stable across environments, or should this be parameterized?
3. Has this change been tested to ensure the log delivery continues to work correctly?

[pulumi-bot]

Your site preview for commit 917e557 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16299-917e5578.s3-website.us-west-2.amazonaws.com.

[pulumi-bot]

Your site preview for commit 42b2fa4 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16299-42b2fa49.s3-website.us-west-2.amazonaws.com.

[pulumi-bot]

Your site preview for commit e865efd is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16299-e865efda.s3-website.us-west-2.amazonaws.com.