Skip to content

Conversation

@CamSoper
Copy link
Contributor

Refresh the development container image and update package versions in yarn.lock for improved compatibility and performance.

@claude
Copy link
Contributor

claude bot commented Oct 22, 2025

Review Complete

This PR updates the devcontainer configuration and package dependencies. The changes look good overall.

Summary

Devcontainer changes (.devcontainer/devcontainer.json):

  • Switched to a more modular base image with explicit feature installation
  • Changed Python version from latest to os-provided for better stability
  • Fixed formatting: removed extra blank line and ensured file ends with newline ✓

Package updates (infrastructure/yarn.lock):

  • Fixed @pulumi/query version format from v0.3.0 to 0.3.0 with proper registry resolution
  • Updated TypeScript from 4.9.5 to 5.9.3 (major version bump)
  • Cleaned up duplicate version declarations and improved alphabetical ordering

Recommendations

  1. TypeScript major version bump: The update from TypeScript 4.9.5 to 5.9.3 is a significant change. Consider:

    • Testing any TypeScript-based tooling in the infrastructure directory
    • Verifying no breaking changes affect the build process
    • Checking if any type errors were introduced by the newer compiler
  2. Devcontainer testing: Verify the new devcontainer configuration works as expected:

    • Ensure all language runtimes install correctly
    • Confirm the post-create script runs successfully
    • Test that the development workflow remains functional

Approval Status

The changes follow repository conventions and improve maintainability. Once the TypeScript version change is verified to not introduce issues, this PR is ready to merge.


Mention me (@claude) if you'd like additional reviews or help with any follow-up changes.

@pulumi-bot
Copy link
Collaborator

@CamSoper CamSoper requested a review from stooj October 22, 2025 18:30
@CamSoper CamSoper enabled auto-merge (squash) October 22, 2025 18:30
@pulumi-bot
Copy link
Collaborator

Copy link
Contributor

@stooj stooj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CamSoper CamSoper merged commit ecbb70a into master Oct 22, 2025
8 checks passed
@CamSoper CamSoper deleted the CamSoper/fix-devcontainer branch October 22, 2025 19:08
@CamSoper CamSoper linked an issue Oct 23, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Devcontainer not able to build python due to gpg keyserver issue

3 participants