-
Couldn't load subscription status.
- Fork 255
Update page for on-demand #16356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update page for on-demand #16356
Conversation
Review SummaryThis PR updates the event page to reflect the on-demand format. The changes are mostly good, but there are a few issues to address: Issues FoundLine 50 ( Join Pulumi and [AWS](https://www.pulumi.com/aws#video) for an exclusive chatSuggestion: Join Pulumi and [AWS](/aws/) for an exclusive chatLine 73 ( topics: ["AI", "Automation", " AWS Bedrock", "DevOps"]Suggestion: topics: ["AI", "Automation", "AWS Bedrock", "DevOps"]Minor Style ConsiderationLines 4, 50, and 89: The change from "fireside chat" to "chat" makes the description more concise, which is good. However, "chat" might feel slightly informal for enterprise content. Consider alternatives like "discussion" or "conversation" if you want a more professional tone while maintaining brevity. What Looks Good
Mention @claude if you'd like additional reviews or fixes after addressing these issues. |
Documentation ReviewThank you for updating this event page for on-demand viewing. I've reviewed the changes and found the following issues: Issues Found1. Inconsistent date references (Line 41, 85, 86, 87) The event dates reference October 2025 ( # Current (appears incorrect):
sortable_date: 2025-10-09T12:00:00-04:00
start_date: 2025-10-09T12:00:00-04:00
end_date: 2025-10-09T13:30:00-04:00
# If this should be January 2025:
sortable_date: 2025-01-09T12:00:00-04:00
start_date: 2025-01-09T12:00:00-04:00
end_date: 2025-01-09T13:30:00-04:002. Trailing space in topics tag (Line 73) There's an extra space after "Automation" in the topics list that should be removed for consistency. # Current:
topics: ["AI", "Automation", "AWS Bedrock", "DevOps"]
# Should be:
topics: ["AI", "Automation", "AWS Bedrock", "DevOps"]3. Missing newline at end of file (Line 90) According to AGENTS.md, all markdown files must end with a newline. Please add a blank line after the final 4. Style: Inconsistent hyphenation in description (Line 89) The Positive Changes✓ Correctly updated Please address the issues above, particularly verifying the event date. Mention me (@claude) if you'd like me to review again after making changes. |
|
I don't understand why it failed, can you please take a look @CamSoper @adamgordonbell ? |
|
@SaraDPH It's nothing you did. The build is broken at the moment, along with some of the live site. |
|
Your site preview for commit 7527512 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16356-75275126.s3-website.us-west-2.amazonaws.com. |
Placing the fireside discussion on-demand