Skip to content

Conversation

@vazudew
Copy link
Contributor

@vazudew vazudew commented Oct 24, 2025

Proposed changes

fixes: #16377

Unreleased product version (optional)

Related issues (optional)

@claude
Copy link
Contributor

claude bot commented Oct 24, 2025

Review Summary

LGTM - This PR correctly fixes a command syntax error.

What was fixed

The kubectl create secret command on line 54 was using an incorrect flag format:

  • Before: -from-literal (single dash - incorrect)
  • After: --from-literal (double dash - correct)

Analysis

The fix is correct. Kubectl uses double-dash (--) for long-form flags, following standard GNU/POSIX conventions. The single-dash version would cause the command to fail.

No issues found

  • ✅ Command syntax is now correct
  • ✅ File ends with a newline
  • ✅ Code example follows best practices
  • ✅ No style guide violations
  • ✅ No spelling or grammar issues

Mention @claude if you'd like me to review any updates or provide additional feedback.

@pulumi-bot
Copy link
Collaborator

Copy link
Contributor

@stooj stooj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@stooj stooj enabled auto-merge (squash) October 24, 2025 09:29
@pulumi-bot
Copy link
Collaborator

@stooj stooj merged commit 9dd59b2 into master Oct 24, 2025
8 checks passed
@stooj stooj deleted the fix-16377 branch October 24, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the flag must be --from-literal instead of -from-literal

3 participants