-
Notifications
You must be signed in to change notification settings - Fork 256
WIP: docs: add "Integration testing with pulumitest" blog #16385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Review FeedbackThis is a well-structured and informative blog post about PulumiTest. The content is technical, practical, and includes useful examples. Here are my findings: Issues Found1. Missing The blog post needs a Line 17 (after the first paragraph): 2. Draft status in frontmatter Line 4: The frontmatter has 3. Future publication date Line 3: The date is set to 4. Minor style issue: "simple" terminology Line 67: The phrase "Here's a minimal example testing a simple AWS S3 bucket deployment" uses the word "simple" which the STYLE-GUIDE.md advises against ("Avoid words like 'easy' or 'simple.' These judge difficulty and may alienate readers.") 5. Minor style issue: "straightforward" (similar to simple) Line 57: "Setting up your first integration test is straightforward." - While not explicitly banned, this is similar to "simple/easy" and judges difficulty. Positive Observations
Minor Suggestions (Optional Improvements)
Verification Notes
Action Items
Great work on this post! The content is valuable and well-written. Once these minor issues are addressed, this will be ready to publish. Mention @claude if you'd like me to review again after making changes or if you need help with any fixes. |
212625e to
65ee9f7
Compare
|
@rshade ping on this, still working on getting this merged? |
Proposed changes
Unreleased product version (optional)
Related issues (optional)