-
Couldn't load subscription status.
- Fork 255
Fix obsolete navigation paths in ESC webhooks documentation #16392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates navigation instructions to reflect current Pulumi Cloud UI, where organization webhooks are now found under Integrations > Webhooks rather than Settings > Webhooks. Also reorders sections to present environment webhooks before organization webhooks for better logical flow. Additional cleanup includes removing outdated trial callout and screenshot, fixing Python code example syntax errors, correcting grammar errors, and standardizing list formatting per style guide. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Review SummaryThis PR successfully updates the ESC webhooks documentation with current UI navigation paths and improves overall clarity. The changes are well-structured and address the stated issues. I found a few minor issues to address: Issues Found1. UI Navigation Formatting (line 61)Location: content/docs/esc/environments/webhooks.md:61 The navigation path uses an arrow symbol (→) instead of the standard greater-than symbol (>). Current: 1. In the main Pulumi Cloud navigation, select **Integrations** > **Webhooks**.Issue: The STYLE-GUIDE.md specifies using arrows for navigation (e.g., Settings → API Keys), but this appears to be using the greater-than symbol ( Suggestion: 1. In the main Pulumi Cloud navigation, select **Integrations** → **Webhooks**.2. Missing Navigation Arrow (line 42)Location: content/docs/esc/environments/webhooks.md:42 The first bulleted item references UI navigation but doesn't use the navigation arrow format consistently. Current: 1. Manually, in the Pulumi Cloud UI using the steps outlined in [Create an Organization Webhook in the Pulumi Cloud UI](#create-an-organization-webhook-in-the-pulumi-cloud-ui) or [Create an Environment Webhook in Pulumi Cloud in the Pulumi Cloud UI](#create-an-environment-webhook-in-the-pulumi-cloud-ui).Issue: Minor - the phrasing "Create an Environment Webhook in Pulumi Cloud in the Pulumi Cloud UI" has a redundant "in Pulumi Cloud" that makes it awkward. Suggestion: 1. Manually, in the Pulumi Cloud UI using the steps outlined in [Create an Organization Webhook in the Pulumi Cloud UI](#create-an-organization-webhook-in-the-pulumi-cloud-ui) or [Create an Environment Webhook in the Pulumi Cloud UI](#create-an-environment-webhook-in-the-pulumi-cloud-ui).3. Bullet List Formatting (line 425)Location: content/docs/esc/environments/webhooks.md:425-426 Current: - [Managing Github Webhooks with Pulumi](/blog/managing-github-webhooks-with-pulumi/)
- [Pulumi Cloud REST API](/docs/pulumi-cloud/cloud-rest-api/)Issue: The change from asterisk ( Positive Changes
Verification Checklist
Mention @claude if you'd like me to review any updates or need additional assistance with these changes. |
|
Your site preview for commit 1035af7 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16392-1035af7e.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For organization webhooks, a user needs to be an admin of the org to set these up. Can you add that requirement somewhere?
Regarding the location, I would write Settings > Integrations to indicate that one needs to expand Settings first to find the Integrations item.
Do ESC environment webhooks also require admin permissions? I'm not sure about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fixes!
…tion webhooks Addresses PR feedback by documenting that organization webhook creation requires admin permissions and correcting the navigation path to Settings > Integrations > Webhooks. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Your site preview for commit 9594bb6 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16392-9594bb67.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit da1f7c6 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16392-da1f7c6a.s3-website.us-west-2.amazonaws.com. |
Fixes #16390
Updates navigation instructions to reflect current Pulumi Cloud UI, where organization webhooks are now found under Integrations > Webhooks rather than Settings > Webhooks. Also reorders sections to present environment webhooks before organization webhooks for better logical flow.
Additional cleanup includes removing outdated trial callout and screenshot, fixing Python code example syntax errors, correcting grammar errors, and standardizing list formatting per style guide.
🤖 Generated with Claude Code