Skip to content

Conversation

@SaraDPH
Copy link
Contributor

@SaraDPH SaraDPH commented Nov 5, 2025

Proposed changes

Unreleased product version (optional)

Related issues (optional)

@claude
Copy link
Contributor

claude bot commented Nov 5, 2025

Documentation Review

I've reviewed this PR that adds a new right nav ad image. Here are my findings:

Issues Found

Incomplete Implementation

The PR adds the image file static/images/docs/ad/neo-pulumi-policies-ad.png but doesn't update the HTML partials that reference ad images. The image is not being used anywhere in the codebase.

Files that need updating:

  • layouts/partials/docs/right-nav-ad.html:3 - Currently references neo-policy-ad.gif
  • layouts/partials/tutorials/right-nav-ad.html:3 - Currently references neo-policy-ad.gif

Suggested fix:

<!-- In layouts/partials/docs/right-nav-ad.html and layouts/partials/tutorials/right-nav-ad.html -->
<div class="mt-8 docs-marketing-ad w-44">
    <a href="/product/pulumi-insights" data-track="docs-neo-pulumi-policies-ad">
        <img src="/images/docs/ad/neo-pulumi-policies-ad.png"
            alt="Neo just got smarter about infrastructure policy automation" />
    </a>
</div>

Additional Observations

Image File Size: The image is 355KB (1042x1251 PNG), which is reasonable for an ad image but on the larger side. Consider optimizing if possible.

Image Format: The new image is a static PNG, while the current ad uses an animated GIF (neo-policy-ad.gif). Confirm this change from animated to static is intentional.

Missing Alt Text Update: If the ad content has changed significantly, the alt text may need updating to accurately describe the new image.


Please update the HTML partials to reference the new image, or clarify if this image is intended for a different purpose. Feel free to mention me (@claude) if you'd like additional reviews or fixes after making updates.

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@SaraDPH SaraDPH merged commit 339ac06 into master Nov 5, 2025
8 checks passed
@SaraDPH SaraDPH deleted the Update-ad-policies branch November 5, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants