-
Notifications
You must be signed in to change notification settings - Fork 258
BYOK and improved crypto capabilities for self-hosted #16604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation ReviewI've reviewed the changes in this PR. Here are my findings: Issues FoundFile: content/docs/administration/self-hosting/changelog.mdLine 29: Missing period after "Breaking Change:" Line 29: Link uses relative path with fragment Suggestion: Update the link to point to the correct section: Breaking Change: Ensure your encryption service permissions are up-to-date with the instructions given [here](/docs/administration/self-hosting/components/api/#aws-kms) and [here](/docs/administration/self-hosting/components/api/#azure-key-vault).Or better yet, make the link text more descriptive: Breaking Change: Ensure your [AWS KMS](/docs/administration/self-hosting/components/api/#aws-kms) and [Azure Key Vault](/docs/administration/self-hosting/components/api/#azure-key-vault) encryption service permissions are up-to-date.File: content/docs/administration/self-hosting/components/api.mdLine 134: Heading case issue Line 134-135: Passive voice Define the following actions in the key's key policy in AWS KMS. Otherwise, the service will fail to start or will not be able to run crypto operations:Line 154: Heading readability #### Mandatory key operations or permissionsLine 157: Passive voice Configure the key in Azure KeyVault to support and allow the following operations. Otherwise, the service will fail to start or will not be able to run crypto operations:Lines 165-167: Missing variable documentation
Positive Aspects✓ Proper use of warning notes shortcode Recommendations
Mention @claude if you'd like me to review any updates or provide additional feedback on specific sections. |
|
Your site preview for commit 187fa60 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16604-187fa600.s3-website.us-west-2.amazonaws.com. |
This is intentional. The variable is not needed anymore (for a longer time). This is a non-breaking change as the variable is just ignored if still set. Azure KeyVault now always uses the latest version to encrypt data and will use the key version stored besides the data to decrypt it. The info that older keys must not be deleted or disabled can be found in the info box above the table. |
|
Your site preview for commit 8ba8cd1 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16604-8ba8cd13.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit 8536da1 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16604-8536da16.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit ee0a7cc is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16604-ee0a7cc6.s3-website.us-west-2.amazonaws.com. |
This PR adds a changelog entry for BYOK and improved crypto capabilities for self-hosted as these feature will be enabled soon.
Additionally a breaking change warning is added as admins need to double check their encryption service permissions.
The self-hosted encryption service instructions are updated accordingly as well.