Skip to content

Conversation

@rshade
Copy link
Contributor

@rshade rshade commented Jan 10, 2025

No description provided.

@rshade rshade requested a review from t0yv0 January 10, 2025 16:29
@rshade rshade self-assigned this Jan 10, 2025
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! But we need to verify these. Did you get a chance to verify manually? I've checked Go test runners and it does not appear that these are under verification in CI.

@rshade
Copy link
Contributor Author

rshade commented Jan 10, 2025

I can check it manually. I figured the unit tests were testing them.

@rshade
Copy link
Contributor Author

rshade commented Jan 10, 2025

I had to add some timeouts to get the test to work locally:

  BucketPair
    constructor
Testing outputs: {
  contentBucketName: 'my_content_bucket',
  logsBucketName: 'my_logs_bucket'
}
      ✔ must pass bucket names (142ms)


  1 passing (6s)```

@rshade
Copy link
Contributor Author

rshade commented Jan 10, 2025

examples/testing-integration-py on  fix-1716 via   via 🐍 v3.11.9 (venv) on ☁️  pulumi-team-ce (us-west-2) on ☁️  richard@pulumi.com took 16s
❯ pulumi up --yes
Please choose a stack, or create a new one: <create a new stack>
Please enter your desired stack name: dev
Created stack 'dev'
Previewing update (dev):
     Type                 Name              Plan
 +   pulumi:pulumi:Stack  s3-py-it-dev      create
 +   └─ aws:s3:BucketV2   pulumi-it-bucket  create

Outputs:
    bucket_name: "pulumi-it-bucket-314acaf"
    region     : output<string>

Resources:
    + 2 to create

Updating (dev):
     Type                 Name              Status
 +   pulumi:pulumi:Stack  s3-py-it-dev      created (5s)
 +   └─ aws:s3:BucketV2   pulumi-it-bucket  created (2s)

Outputs:
    bucket_name: "pulumi-it-bucket-99c47f7"
    region     : "us-west-2"

Resources:
    + 2 created

Duration: 8s```

@rshade rshade enabled auto-merge (squash) January 10, 2025 21:14
@rshade rshade merged commit beeac20 into master Jan 10, 2025
41 checks passed
@rshade rshade deleted the fix-1716 branch January 10, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants