Fix gcp oidc audience #2198
Merged
Fix gcp oidc audience #2198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehsis
approved these changes
Sep 19, 2025
|
for my own education, in what cases would someone want to set edit: ohh, escEnvOrg drives which org the environment is actually deployed into, derp. |
Contributor
Author
|
@nyobe someone can set it if they want to create an environment in a specific org. but we're always setting audience to the default org (which could be different). this fix makes it so that it uses the same org for both |
joeduffy
reviewed
Sep 19, 2025
|
|
||
| const oidcProvider = new gcp.iam.WorkloadIdentityPoolProvider(`identity-pool-provider`, { | ||
| workloadIdentityPoolId: identityPool.workloadIdentityPoolId, | ||
| workloadIdentityPoolProviderId: `pulumi-cloud-${pulumi.getOrganization()}-oidc`, |
Member
There was a problem hiding this comment.
Should this also be escEnvOrg?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not setting the audience correctly if escEnvOrg is set in config. they need to always match