(BKR-1484) Packaging platform overrides for puppet5 install utils #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseywilliams
force-pushed
the
BKR-1484/platform-overrides
branch
from
d0e2a76 to
d537b16
Compare
branan
reviewed
Jul 3, 2018
| if ENV['BEAKER_PACKAGING_PLATFORMS'] | ||
| overrides = Hash[ENV['BEAKER_PACKAGING_PLATFORMS'].split(',').map { |e| e.split('=') }] | ||
| logger.debug("Found packaging platform overrides: #{overrides}") | ||
| if overrides[host[:packaging_platform]] |
There was a problem hiding this comment.
Shouldn't this be looking up overrides for host[:platform]?
Contributor
Author
There was a problem hiding this comment.
Yeah, it should -- my aix tests just happened to work out for that specific case anyway. I'll update.
Allows the environment variable BEAKER_PACKAGING_PLATFORMS to override the default packaging platforms specified for hosts by beaker-hostgenerator in `host_urls`. BEAKER_PACKAGING_PLATFORMS should be a comma-separated list with entries of the format `<platform-name>=<packaging-platform-name>`.
caseywilliams
force-pushed
the
BKR-1484/platform-overrides
branch
from
d537b16 to
97d6eaa
Compare
Contributor
Author
|
The PR test failure looks transient |
Contributor
Author
|
jenkins please test this |
branan
approved these changes
Jul 3, 2018
smcclellan
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the environment variable BEAKER_PACKAGING_PLATFORMS to override
the default packaging platforms specified for hosts by
beaker-hostgenerator in
host_urls. BEAKER_PACKAGING_PLATFORMS shouldbe a comma-separated list with entries of the format
<platform-name>=<packaging-platform-name>.Here's an example run of puppet-agent and puppet acceptance, with
BEAKER_PACKAGING_PLATFORMS="aix-7.1-power=aix-6.1-power,aix-7.2-power=aix-6.1-power"set on puppet-agent only; The puppet-agent tests install the 6.1 package on 7.1 and 7.2, and the puppet tests (which don't use the environment variable) fail, because they still look for 7.1 and 7.2 packages, which aren't available in this run.