(MAINT)(gh-210) series of commits to get beaker smoketest working in ec2#392
(MAINT)(gh-210) series of commits to get beaker smoketest working in ec2#392colinPL merged 3 commits intovoxpupuli:masterfrom
Conversation
anodelman
commented
Aug 7, 2014
anodelman
commented
- updates to aws_sdk hypervisor support to correctly use vmhostname, hostname and ip
- additional open ports for ec2 instances
- updates to dsl 'on' method to properly handle additional environment variables
- 61613 needs to be open for MCO to work correctly
- vmhostname was being set incorrectly and breaking PE installation - move instance metadata tag addition to after instance is running - /etc/hosts generation fixed so that it has entries for all other hosts on each individual host - add agent listen port (8139) - fix zombie killing by correctly handling volumes that may not exist when attempted deletion occurs
- we do not correctly handle adding additional environment variables to puppet commands, this patch allows you to add those env vars
|
💚 Test passed. |
There was a problem hiding this comment.
I understand that Beaker::Command is in scope here as Command and that it is relatively common to use the unqualified in-scope name of a class/module both in the Ruby community and in Beaker, but I am curious if you are aware of any reasons not to use the fully-qualified version?
I personally prefer less ambiguity where possible, but I'm not suggesting a change should be made--just interested in discussion about coding conventions within Beaker.
There was a problem hiding this comment.
Sounds like something that could make it into a standard - we don't currently have a preferred format.
|
@anodelman +1 from me generally, as long as we've tested this on EC2 against PuppetDB I guess. |
|
Yup, green on PuppetDB smoketests. |
(MAINT)(gh-210) series of commits to get beaker smoketest working in ec2
5 participants
