Merge npwalker/control-repo in puppetlabs/control-repo #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stole Gary's puppet_repository and modified it for general general consumption. Upped the version of r10k to newest (1.4.1) Ripped out the hiera examples just left defaults.yaml Tweaked environment.conf
Comment out Gary's examples
Added hunner/hiera to the Puppetfile and a manifest to use it instead of placing a hiera.yaml in the repo.
The config_version now uses a script that will do one of two things: 1. call config_version.rb which uses rugged to find the information about the latest commit if PE is on version 2015.2 or newer 2. make a call to git if the PE version is less than 2015.2
Allow including a role if defined via a trusted fact on the node during provisioning time. This is how I will bootstrap any necessary configuration on the master, or other PE internal nodes.
Updating README for instructions on how to use the control-repo by putting it in your own git server and then using the r10k answers during installation of PE. Removing the manifest for configuring r10k using zack/r10k. Added a role that can be used to bootstrap an all-in-one PE installation.
I thought I needed to double quote items that had interpolated variables but it turns out I don't need to which is good because I effectively can't due to .to_yaml not doing what I wanted it to do.
I need a way to tune my VMs to use less memory and this allows me to do that.
This entailed configring the classifier to never sync on a schedule. Changing environment_timeout to unlimited for all masters. Setting a postrun command for r10k that would update the class information in the classifier (the update-classes endpoint).
The abrader/gms provider for gitlab doesn't support disabling ssl verification but will soon.
Also, change other references of $fqdn to $::fqdn
To accomodate generating random usernames and passwords, I had to parameterize the profiles which I didn't feel great about but I also didn't want to have to put the username and pass in hiera.
Previously there was a mcollective and no_mcollective version of the webhook profile. They were almost identical so I merged them and manage the difference with a "use_mcollective" parameter. I renamed the webhook profile to zack_r10k_webhook.
When the owner / group was root this meant that enabling hiera-eyaml wouldn't work properly as the keys couldn't be read by puppetserver. Changing to pe-puppet should resolve the issue.
…into merge_npwalker_control_repo
Contributor
|
There's a lot going on here and I'd love to see it evolve to be simpler to get set up. That said, this is a work in progress and importantly, this code is actually being used in the real world and iterated on. Merge it, I say! Can I get another 👍 ? |
|
I'm definitely 👍 but I also asked him to do it. It follows along the lines of what we're doing in the field, so this is great |
README.md
Outdated
Contributor
Author
There was a problem hiding this comment.
okay added a commit to remove that url
Remove a specific reference to the npwalker namespace in a git clone command. Add some notes that this has only been tested against 2015.2.z.
|
I'll give it until EOD today, if nobody dissents I'll hit the merge button. I use this on most of my gigs, so if something arises we'll file a PR and correct it. |
There was a problem hiding this comment.
add profile::base here, since other roles say all roles should include profile::base, perhaps?
|
Looking good to me! 👍 I would like to see a Gemfile and Rakefile for some basic checks, but thats probably another PR |
|
With nobody dissenting, I'm merging! |
glarizza
pushed a commit
that referenced
this pull request
Nov 25, 2015
Merge npwalker/control-repo in puppetlabs/control-repo
npwalker
referenced
this pull request
in Puppet-RampUpProgram/control-repo
May 12, 2016
Add step to create ssh directory and clarify "Test Code Manager" steps.
kenazk
pushed a commit
to kenazk/control-repo
that referenced
this pull request
Oct 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.