(FACT-3171) Fix IPv6 link-local unicast address filtering #2539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch? |
smortex
changed the title
smortex
force-pushed
the
fix-ipv6-link-local-unicast-address-filtering
branch
2 times, most recently
from
791b033 to
78a558d
Compare
smortex
changed the title
joshcooper
reviewed
Jan 3, 2023
joshcooper
reviewed
Jan 3, 2023
smortex
force-pushed
the
fix-ipv6-link-local-unicast-address-filtering
branch
from
78a558d to
ca8d6d0
Compare
Contributor
Instead of String comparison, check if IP addresses are included into the ignored ranges. No functional change.
RFC4291 define the Link-local unicast range as fe80::/10, not fe80::/16. As a consequence some Link-local unicast addresses where not correctly filtered, e.g. fe87::. While here, add a "working" example with an actual global IPv6 address from the 2001:0DB8::/32 range reserved for documentation (RFC3849).
smortex
force-pushed
the
fix-ipv6-link-local-unicast-address-filtering
branch
from
ca8d6d0 to
c273b76
Compare
Contributor
Author
|
Awesome! Thanks for the head-up! |
joshcooper
approved these changes
Jan 6, 2023
Contributor
joshcooper
left a comment
joshcooper
left a comment
There was a problem hiding this comment.
Looks correct to me based on https://www.rfc-editor.org/rfc/rfc4291.html#section-2.4
Link-Local unicast 1111111010 FE80::/10 2.5.6
and https://www.rfc-editor.org/rfc/rfc5735.html#section-3
169.254.0.0/16 - This is the "link local" block. As described in
[RFC3927], it is allocated for communication between hosts on a
single link. Hosts obtain these addresses by auto-configuration,
such as when a DHCP server cannot be found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC4291 define the Link-local unicast range as
fe80::/10, notfe80::/16(what we compared against because of the String comparison). As a consequence, some Link-local unicast addresses where not correctly filtered, e.g.fe87::.While here, add a "working" example with an actual global IPv6 address from the
2001:0DB8::/32range reserved for documentation (RFC3849).