(maint) Reset facter search path when resetting facts #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of Facter search paths was only additive and there was no way to remove Facter search paths once added. This is especially problematic when running the Puppet specs which wind up reloading Facter frequently and adding search paths, and can wind up adding thousands of meaningless paths. This commit resets the Facter search path on `Facter.reset` so that when facts are reset, the known search pats are reset as well.
|
CLA signed by all contributors. |
kylog
pushed a commit
that referenced
this pull request
Feb 11, 2014
…h-path-on-reset (maint) Reset facter search path when resetting facts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of Facter search paths was only additive and
there was no way to remove Facter search paths once added. This is
especially problematic when running the Puppet specs which wind up
reloading Facter frequently and adding search paths, and can wind up
adding thousands of meaningless paths. This commit resets the Facter
search path on
Facter.resetso that when facts are reset, the knownsearch pats are reset as well.