(Maint) - remove deb family system volume #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `deb_family_systemd_volume` logic hardcoded a `--volume /sys/fs/cgroup:/sys/fs/cgroup:ro` flag when provisioning Debian or Ubuntu containers in order to allow SystemD to run. However, this mount is no longer sufficient when the docker host is running a Kernel with CGroupsV2 and a SystemD version that defaults to using `systemd.enableUnifiedCgroupHierarchy=true`: docker/for-mac#6073 Ubuntu 22.04 fits these criteria. In these conditions, `--cgroupns=host -v /sys/fs/cgroup:/sys/fs/cgroup:rw` must be used. However, attempting to pass these flags to `docker_exp` via `docker_run_opts` causes `docker run` to fail due to a conflict with the hardcoded mount from `deb_family_systemd_volume`: ``` stderr:docker: Error response from daemon: Duplicate mount point: /sys/fs/cgroup. ``` This commit removes the `deb_family_systemd_volume` logic as: - CGroup mounts must be configured for any OS family using SystemD, not just Debian and Ubuntu. - The user should be able to exercise full control over mount flags via `docker_run_opts`.
jordanbreen28
force-pushed
the
maint-remove_deb_family_system_volume
branch
6 times, most recently
from
0383ad0 to
e4a6130
Compare
This commit removes any reference to deb_family_system_volume.
jordanbreen28
force-pushed
the
maint-remove_deb_family_system_volume
branch
3 times, most recently
from
949fc29 to
b69d32d
Compare
jordanbreen28
force-pushed
the
maint-remove_deb_family_system_volume
branch
15 times, most recently
from
0fcd482 to
a1d0cc3
Compare
jordanbreen28
force-pushed
the
maint-remove_deb_family_system_volume
branch
5 times, most recently
from
e615942 to
cffc02c
Compare
jordanbreen28
force-pushed
the
maint-remove_deb_family_system_volume
branch
from
cffc02c to
9bd9713
Compare
chelnak
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #198.
Thanks for your contribution on this one @Sharpie :-)