Skip to content

(PA-2055) Get boost and yaml-cpp from puppet-runtime #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2018
Merged

(PA-2055) Get boost and yaml-cpp from puppet-runtime #1482

merged 2 commits into from
Jul 26, 2018

Conversation

@caseywilliams
Copy link
Contributor

@caseywilliams caseywilliams commented Jul 12, 2018 •
edited
Loading

Do not merge; This is a WIP PR

Will require puppetlabs/puppet-runtime#77

@caseywilliams caseywilliams mentioned this pull request Jul 12, 2018
Closed
@puppetcla
Copy link

CLA signed by all contributors.

@caseywilliams caseywilliams force-pushed the PA-2055/runtime-boost-yaml-cpp branch 2 times, most recently from f173fce to ba0cb37 Compare July 16, 2018 16:28
This was referenced Jul 17, 2018
Merged
Merged
Merged
Merged
@caseywilliams
Copy link
Contributor Author

caseywilliams commented Jul 17, 2018 •
edited
Loading

Blocked on:

This was referenced Jul 17, 2018
Merged
Merged
@caseywilliams caseywilliams force-pushed the PA-2055/runtime-boost-yaml-cpp branch 6 times, most recently from cefb1ef to c3c9420 Compare July 23, 2018 23:24
@caseywilliams
Copy link
Contributor Author

jenkins please test this on aix61-POWERfa,amazon6-64a,amazon7-64a,arista4-32a,ciscoxr-64a,cumulus25-64a,debian8-64a,debian8-32a,debian9-64a,debian9-32a,fedora26-64a,fedora27-64a,fedora28-64a,osx1012-64a,osx1013-64a,redhat5-64a,redhat6-64a,redhat6-32a,redhat7-64a,redhat7-POWERa,redhat7-AARCH64a,redhatfips7-64a,sles11-64a,sles11-32a,sles12-64a,sles12-POWERa,solaris10-64a,solaris10-SPARCa,solaris11-64a,solaris11-SPARCa,ubuntu1404-64a,ubuntu1404-32a,ubuntu1604-64a,ubuntu1604-32a,ubuntu1604-POWERa,ubuntu1804-64a,windows10ent-64a,windows10ent-32a,windows2008r2-64a,windows2012r2-64a,windows2012r2_ja-64a%7Blocale=ja%7D,windows2016-64a

@caseywilliams caseywilliams force-pushed the PA-2055/runtime-boost-yaml-cpp branch from 5fda29e to c3c9420 Compare July 24, 2018 03:38
@caseywilliams
Copy link
Contributor Author

jenkins please test this on arista4-32a,ciscoxr-64a,cumulus25-64a,osx1012-64a,windows2012r2-64a

@caseywilliams caseywilliams force-pushed the PA-2055/runtime-boost-yaml-cpp branch from 54e5972 to 6d0938e Compare July 25, 2018 20:46
@caseywilliams
Copy link
Contributor Author

jenkins please test this on arista4-32a,ciscoxr-64a,cumulus25-64a,osx1012-64a,windows2012r2-64a

@caseywilliams caseywilliams force-pushed the PA-2055/runtime-boost-yaml-cpp branch 2 times, most recently from 8a305f1 to d1ddec5 Compare July 25, 2018 21:25
@caseywilliams
Copy link
Contributor Author

jenkins please test this on arista4-32a,ciscoxr-64a,cumulus25-64a,osx1012-64a,windows2012r2-64a

@caseywilliams caseywilliams force-pushed the PA-2055/runtime-boost-yaml-cpp branch from d1ddec5 to c26db12 Compare July 25, 2018 22:07
@caseywilliams
Copy link
Contributor Author

jenkins please test this on arista4-32a,ciscoxr-64a,cumulus25-64a,osx1012-64a,windows2012r2-64a

@caseywilliams caseywilliams force-pushed the PA-2055/runtime-boost-yaml-cpp branch from c26db12 to 8ab6e14 Compare July 26, 2018 15:51
@caseywilliams
(PA-2055) Update cpp-hocon to c710b8cd407339f7f6f3215028fc51cf50695f06
8214b44 
This revision of cpp-hocon ignores some warnings generated by
Boost.Variant headers in boost 1.67.
@caseywilliams
(PA-2055) Use boost and yaml-cpp from puppet-runtime
392bcd7 
Previously, boost and yaml-cpp were provided by separate packages,
whether that meant using pl-build-tools (pl-boost and pl-yaml-cpp) or
equivalent system packages.

This set of changes updates the configuration of C++ components to rely
on copies of boost (version 1.67) and yaml-cpp from puppet-runtime
instead. It also links these libraries dynamically instead of statically
in the agent.
@caseywilliams caseywilliams force-pushed the PA-2055/runtime-boost-yaml-cpp branch from 8ab6e14 to b0e7939 Compare July 26, 2018 17:44
@caseywilliams
Copy link
Contributor Author

These changes have passed acceptance tests in an ad-hoc run here, with the exception of:

  • puppet tests, which are affected by an unrelated breaking change in beaker, and
  • unrelated networking issues on cisco VMs

Once puppetlabs/puppet-runtime#77 is merged, I'll remove the WIP commit here and this will be ready to merge.

@caseywilliams caseywilliams force-pushed the PA-2055/runtime-boost-yaml-cpp branch from b0e7939 to 392bcd7 Compare July 26, 2018 23:41
@branan branan merged commit 8ed9d81 into puppetlabs:master Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@caseywilliams @puppetcla @branan