(GH-147) Gracefully fail on LoadError when compiling manifests #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the sidecar would error completely when a LoadError was encountered. This could be caused by gem Facter trying to load libraries which are not present. StandardError does not trap these. This commit also traps the LoadError and allows the sidecar to return a properly formatted response to Editor Services intead of dumping error text to STDERR.
Contributor
Author
|
No tests required for this. |
jpogran
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
Note - Technically this doesn't fix the error, but at least Editor Services will not crashing or throw bad data. The fact a gem is missing from the ruby environment is outside the control of Editor Services.
Previously the sidecar would error completely when a LoadError was encountered.
This could be caused by gem Facter trying to load libraries which are not
present. StandardError does not trap these. This commit also traps the
LoadError and allows the sidecar to return a properly formatted response to
Editor Services intead of dumping error text to STDERR.