(GH-177) Dynamically unregister capabilities #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously capability registrations were assumed to only have one possible reqeuest per method however this isn't true. Also the request ID is needed in order to unregister a capability. This commit; * Modifies the Language Client to track registrations that are in progress and have completed * Now processes error messages so that registration tracking can fail tracked registrations * Adds tests for these scenarios
…ient Previously the message router was passed in as a method parameter however as almost all methods require the message router, this commit changes the initializer to pass in the message router at object create time.
Previously client capabilities could be dynamically registered. This commit adds the logic and track to dynamically unregister a capability; * Adds the unregister_capability and parse_unregister_capability_response! methods * Adds the client/unregisterCapability notification handler * Adds tests for unregistering
jpogran
approved these changes
Sep 18, 2019
Contributor
jpogran
left a comment
jpogran
left a comment
There was a problem hiding this comment.
Paired with @glennsarti and we reviewed code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #177
Previously capability registrations were assumed to only have one possible
reqeuest per method however this isn't true. Also the request ID is needed in
order to unregister a capability. This commit;
have completed
registrations
Previously the message router was passed in as a method parameter however as
almost all methods require the message router, this commit changes the
initializer to pass in the message router at object create time.
Previously client capabilities could be dynamically registered. This commit
adds the logic and track to dynamically unregister a capability;
methods