(GH-272) Puppet Lint and document symbol sometimes not working #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously in commit fed22c2 the document symbol provider was updated to use the new LSP classes however it appears some code branches were missed. This commit updates the document symbol provider to use the correct method name.
Previously the Puppet-Lint configuration could raise an error, thereby stopping any puppet lint rules from working. This was due to puppet-lint.rc files containing command params which were invalide due to puppet-lint plugin gems not being loaded e.g. --no-trailing_comma-check This commit changes the document validator to use the default configuration if an error occurs loading the configuration.
glennsarti
force-pushed
the
spike-fix-broken-stuff
branch
from
414fa90 to
327bd50
Compare
jpogran
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in commit fed22c2 the document symbol provider was updated
to use the new LSP classes however it appears some code branches were missed.
This commit updates the document symbol provider to use the correct method name.
Previously the Puppet-Lint configuration could raise an error, thereby stopping
any puppet lint rules from working. This was due to puppet-lint.rc files
containing command params which were invalide due to puppet-lint plugin gems
not being loaded e.g. --no-trailing_comma-check
This commit changes the document validator to use the default configuration if
an error occurs loading the configuration.