Skip to content

Conversation

@glennsarti
Copy link
Contributor

@glennsarti glennsarti commented Dec 4, 2018

Fixes #88

The object cache contains all of the type, function and class information so it
should be easily be able to be queried and then emit these results as part of a
workspace symbol request (as opposed to document symbol). This commit adds the
provider and cache methods to support querying all objects in the cache.

@glennsarti glennsarti force-pushed the spike-add-workspace-symbols branch from de4967a to 96a10f7 Compare December 7, 2018 05:43
@jpogran jpogran added this to the 0.17.0 milestone Dec 11, 2018
@glennsarti glennsarti force-pushed the spike-add-workspace-symbols branch from 96a10f7 to 87c67fa Compare December 11, 2018 03:17
@glennsarti glennsarti changed the title {WIP} (TODO) Spike add workspace symbols (GH-88) Spike add workspace symbols Dec 11, 2018
@glennsarti glennsarti added enhancement New feature or request Language Server labels Dec 11, 2018
@glennsarti glennsarti requested a review from jpogran December 11, 2018 03:18
@glennsarti
Copy link
Contributor Author

A later PR will add tests.

Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

The object cache contains all of the type, function and class information so it
should be easily be able to be queried and then emit these results as part of a
workspace symbol request (as opposed to document symbol).  This commit adds the
provider and cache methods to support querying all objects in the cache.
@glennsarti glennsarti force-pushed the spike-add-workspace-symbols branch from 87c67fa to fb1736d Compare December 11, 2018 03:38
This commit updates new rubocop violations and increases the test timeout due
to failures on Travis.
@glennsarti glennsarti force-pushed the spike-add-workspace-symbols branch from fb1736d to 24fbfdd Compare December 11, 2018 05:11
@glennsarti glennsarti changed the title (GH-88) Spike add workspace symbols (GH-88) Add workspace symbols provider Dec 11, 2018
@glennsarti
Copy link
Contributor Author

@jpogran Ready for merge

Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot!

@jpogran jpogran merged commit 2cc861a into puppetlabs:master Dec 13, 2018
@glennsarti glennsarti deleted the spike-add-workspace-symbols branch February 8, 2019 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants