(CAT-2092) - Add workflow restarter #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danadoherty639
force-pushed
the
cat_2092
branch
2 times, most recently
from
be53cc7 to
a84164d
Compare
There was a problem hiding this comment.
Couple of comments @danadoherty639 - going to change label to maintenance as its CI work and doesnt need to appear in the changelog :)
.github/workflows/nightly.yml
Outdated
| bundle exec rake spec | ||
| on-failure-workflow-restarter-proxy: | ||
| # (1) run this job after the "acceptance" job and... |
There was a problem hiding this comment.
both comments need updating as refer to acceptance job which is a bit misleading
.github/workflows/ci.yml
Outdated
| run: | | ||
| bundle exec rake spec | ||
| on-failure-workflow-restarter-proxy: |
There was a problem hiding this comment.
not sure we should be adding this to ci.yml, and only in nightly.yml like other repos, what do you think?
There was a problem hiding this comment.
Completely agree, I'm just doing this for testing purposes, maybe its best I change it to a draft PR for now as still have a few tweaks to make to the workflow-restarter action. Thanks Jordan :)
jordanbreen28
added
maintenance
danadoherty639
force-pushed
the
cat_2092
branch
10 times, most recently
from
c075cca to
4b8bce6
Compare
danadoherty639
force-pushed
the
cat_2092
branch
from
4b8bce6 to
6d588b1
Compare
gavindidrichsen
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist