(#22129) force explicit file content to be treated as a bytestring

This replicates the implicit behavior in Ruby-1.8.7, and avoids chasing
down every location where a value is passed to `should=` and setting the
encoding there.

Author: djmitche

lib/puppet/type/file/content.rb

@@ -133,6 +133,9 @@ def retrieve
 
     # Make sure we're also managing the checksum property.
     def should=(value)
+      # treat the value as a bytestring, in Ruby versions that support it, regardless of the encoding
+      # in which it has been supplied
+      value = value.clone.force_encoding(Encoding::ASCII_8BIT) if value.respond_to?(:force_encoding)
       @resource.newattr(:checksum) unless @resource.parameter(:checksum)
       super
     end

spec/unit/type/file/content_spec.rb

@@ -84,6 +84,15 @@
 
       @content.should.must == string
     end
+
+    if "".respond_to? :encode then
+      it "should convert the value to ASCII-8BIT" do
+        @content = content.new(:resource => @resource)
+        @content.should= "Let's make a \u{2603}"
+
+        @content.actual_content.should == "Let's make a \xE2\x98\x83"
+      end
+    end
   end
 
   describe "when retrieving the current content" do