Skip to content

Commit d58e2a2

Browse files
committed
(PUP-3376) Log critical errors at the error level
Commit 1d5386a modified the windows daemon to observe puppet's log_level. This added `log_XXX` methods for alert, emerg, and crit log levels. Although the service never tried to log at those levels, if it did, the message would have been logged to the Application event log as EVENTLOG_WARNING_TYPE. This commit future-proofs the code to ensure that :alert, :emerg, and :crit are logged as EVENTLOG_ERROR_TYPE.
1 parent 9c54d41 commit d58e2a2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ext/windows/service/daemon.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def log(msg, level)
129129
case level
130130
when :debug, :info, :notice
131131
report_windows_event(EVENTLOG_INFORMATION_TYPE,0x01,msg.to_s)
132-
when :err
132+
when :err, :alert, :emerg, :crit
133133
report_windows_event(EVENTLOG_ERROR_TYPE,0x03,msg.to_s)
134134
else
135135
report_windows_event(EVENTLOG_WARNING_TYPE,0x02,msg.to_s)

0 commit comments

Comments
 (0)