(PUP-4435) Remove unneeded expectations

Removes the `chuser` expectations when testing for deprecation notice as
that is tested in the `user privileges` context, and refactors stubbing
`:rack` options to the before each hook.

Author: joshcooper

spec/unit/application/master_spec.rb

@@ -339,10 +339,6 @@ def a_user_type_for(username)
       end
 
       it "should log a deprecation notice when running a WEBrick server" do
-        Puppet.features.stubs(:root?).returns true
-        a_user_type_for("puppet").expects(:exists?).returns true
-        Puppet::Util.expects(:chuser)
-
         Puppet.expects(:deprecation_warning).with("The WEBrick Puppet master server is deprecated and will be removed in a future release. Please use Puppet Server instead. See http://links.puppetlabs.com/deprecate-rack-webrick-servers for more information.")
 
         @master.main
@@ -366,29 +362,22 @@ def a_user_type_for(username)
         before do
           require 'puppet/network/http/rack'
           Puppet::Network::HTTP::Rack.stubs(:new).returns(@app)
-        end
 
-        it "it should not start a daemon" do
           @master.options.stubs(:[]).with(:rack).returns(:true)
+        end
 
+        it "it should not start a daemon" do
           @daemon.expects(:start).never
 
           @master.main
         end
 
         it "it should return the app" do
-          @master.options.stubs(:[]).with(:rack).returns(:true)
-
           app = @master.main
           expect(app).to equal(@app)
         end
 
         it "should log a deprecation notice" do
-          @master.options.stubs(:[]).with(:rack).returns(:true)
-          Puppet.features.stubs(:root?).returns true
-          a_user_type_for("puppet").expects(:exists?).returns true
-          Puppet::Util.expects(:chuser)
-
           Puppet.expects(:deprecation_warning).with("The Rack Puppet master server is deprecated and will be removed in a future release. Please use Puppet Server instead. See http://links.puppetlabs.com/deprecate-rack-webrick-servers for more information.")
 
           @master.main