(PUP-6467) Fix Parallel Spec grouping for RSpec 3.5.0 #5098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rspec_grouper currently tries to access an array of example groups through a private function children() in RSpec::Core::ExampleGroups in order to calculate example counts per spec file. With the RSpec 3.5.0 release, the example groups are no longer accessible through children(). So, rspec_grouper cannot find example groups and is reporting that no examples can be found. This commit uses RSpec.world.example_groups instead to access the array.
During work on PUP-6467, it was found that some version_spec tests were modifying Puppet.version value globally, which was affecting tests in integration/indirector/facts/facter_spec.rb. Facter was incorrectly reporting a Puppet version of 1.2.3, instead of 4.6.0 during the tests, causing failures. This commit reverts Puppet.version to its original value after each test in version_spec. It also adds a context block and new test to clarify the functionality of the version setter.
|
CLA signed by all contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rspec_grouper currently tries to access an array of example groups
through a private function children() in RSpec::Core::ExampleGroups
in order to calculate example counts per spec file. With the RSpec
3.5.0 release, the example groups are no longer accessible through
children(). So, rspec_grouper cannot find example groups and is
reporting that no examples can be found.
This commit uses RSpec.world.example_groups instead to access the
array.
Also, version_spec fix.