{WIP}(PUP-7894) Add Scheduled Task V2 API functionality #6198

glennsarti · 2017-09-12T23:33:32Z

Previously Puppet used the V1 API for scheduled tasks however this has been
deprecated in favor of the V2 Win32OLE objects. This commit adds a parent class
which can query and modify tasks via the V2 API and adds a facade class called
Puppet::Util::Windows::TaskScheduler2V1Task which is binary compatible with the
older V1 class Win32::TaskScheduler. This commit also adds basic smoke tests
for the V2 API for CRUD operations.

This commit adds a new non-default provider for the scheduled_task puppet type
which instead uses the V2 API for scheduled tasks. As this is not the default
users will need to opt in to this functionality.

This commit changes the unit tests for the scheduled_task provider by running
the tests against both providers (win32_taskscheduler, the default, and
taskscheduler_api2). This ensures that any behaviors are consistent in both
providers.

The concrete class which services each provider is refactored into the
concrete_klass variable which is then used in the tests themselves.

glennsarti · 2017-09-13T00:39:31Z

Seems I broke posix testing....oh well.

puppetcla · 2017-09-13T01:00:18Z

CLA signed by all contributors.

Iristyle · 2017-09-14T17:08:06Z

The Travis output for bundle exec rake $CHECK is really ... odd:

Processing 42 spec group(s) with 2 worker(s)
error: spec list file 'An' does not exist.
sh: 1: Syntax error: end of file unexpected
error: spec list file 'Failure/Error:' does not exist.
error: spec list file 'if' does not exist.
error: spec list file 'task_provider' does not exist.
error: spec list file 'else' does not exist.
error: spec list file 'task_provider' does not exist.
error: spec list file 'end' does not exist.
sh: 1: Syntax error: "(" unexpected
error: spec list file 'before' does not exist.
error: spec list file 'NameError:' does not exist.
error: spec list file 'uninitialized' does not exist.
sh: 1: Syntax error: "(" unexpected

glennsarti · 2017-09-14T17:41:41Z

I'm pretty sure it's because I broke something when I shell out to run powershell.

Iristyle · 2017-09-14T17:31:49Z

lib/puppet/util/windows/taskscheduler2.rb

@@ -0,0 +1,707 @@
+#require 'puppet/util/windows/error'
+#require 'win32ole' # TODO should guard this on Windows only


Iristyle · 2017-09-14T17:32:10Z

lib/puppet/util/windows/taskscheduler2.rb

+
+  # TODO May not need this if no COM
+  # require 'ffi'
+  # extend FFI::Library


All these bits can get the axe

Iristyle · 2017-09-14T17:32:20Z

lib/puppet/util/windows/taskscheduler2.rb

+  # extend FFI::Library
+
+  # The error class raised if any task scheduler specific calls fail.
+  class Error < Puppet::Util::Windows::Error; end


Confused by this part....

Iristyle · 2017-09-14T17:32:31Z

lib/puppet/util/windows/taskscheduler2.rb

+  # # TODO needed?
+  # class << self
+  #   attr_accessor :com_initialized
+  # end


Iristyle · 2017-09-14T17:33:53Z

lib/puppet/util/windows/taskscheduler2.rb

+  ROOT_FOLDER = '\\'
+
+  # https://msdn.microsoft.com/en-us/library/windows/desktop/aa378137(v=vs.85).aspx
+  S_OK = 0


This is already defined elsewhere FWIW -

puppet/lib/puppet/util/windows/com.rb

Line 8 in 3a5dfed

S_OK = 0

Ok I can use that instead

Iristyle · 2017-09-14T17:38:23Z

lib/puppet/util/windows/taskscheduler2.rb

+    @task_service = nil
+    @pITask = nil
+
+    # # TODO Do we need COM for OLE?


No.. trash this.

Iristyle · 2017-09-14T17:40:40Z

lib/puppet/util/windows/taskscheduler2_v1task.rb

+    @task.max_run_time_as_ms
+  end
+
+#   # Sets the maximum length of time, in milliseconds, that the task can run


I assume we can trash this?

whoops....forgot to implement that

Iristyle · 2017-09-14T17:47:09Z

lib/puppet/util/windows/taskscheduler2.rb

+    raise Error.new(_('No current task scheduler. Schedule.Service is NULL.')) if @task_service.nil?
+    raise TypeError unless task.is_a?(String)
+
+    task_folder = @task_service.GetFolder(get_folder_path_from_task(task))


The helpers are unnecessary, though you may have to switch from / to \\:

irb(main):005:0> require 'pathname' => true <(File.expand_path('c:\\windows\\tasks\\file.task')) => #<Pathname:c:/windows/tasks/file.task> irb(main):007:0> f.dirname => #<Pathname:c:/windows/tasks> irb(main):008:0> f.basename => #<Pathname:file.task>

These are not File paths. They are backslash delimited paths

Iristyle · 2017-09-14T17:48:12Z

lib/puppet/util/windows/taskscheduler2.rb

+
+    # TODO SHOULD BE  tested
+    def get_folder_path_from_task(task_name)
+      path = task_name.rpartition('\\')[0]


Pathname can do this already, unless you think the helpers are better suited.

These are not File paths. They are backslash delimited paths

Iristyle · 2017-09-14T17:50:55Z

lib/puppet/util/windows/taskscheduler2.rb

+    raise Error.new(_('No current task scheduler. Schedule.Service is NULL.')) if @task_service.nil?
+    raise TypeError unless folder_path.is_a?(String)
+
+    options = {} if options.nil?


Why not assign options = {} as the default value in the method signature?

Yeah...I'll fix that.

Also a note about using the Ruby way of merging options hashs..

Iristyle · 2017-09-14T17:53:20Z

lib/puppet/util/windows/taskscheduler2.rb

+    task_folder.GetTasks(TASK_ENUM_HIDDEN).each do |task|
+      included = true
+
+      unless !included || options[:include_compatibility].empty?


unless + ! makes for a confusing check...

Can probably clean up the logic here inside the loop to make it a bit clearer...

Iristyle · 2017-09-14T18:25:16Z

lib/puppet/util/windows/taskscheduler2_v1task.rb

+#
+class Puppet::Util::Windows::TaskScheduler2V1Task
+  # The error class raised if any task scheduler specific calls fail.
+  class Error < Puppet::Util::Windows::Error; end


Defined here as well?

Spec tests were failing as it was expecting these definitions.

Iristyle · 2017-09-14T18:29:17Z

lib/puppet/util/windows/taskscheduler2.rb

+
+      array << task.Path if included
+    end
+    return array unless options[:include_child_folders]


I think I'd break apart this method a little bit / refactor... I can show you what I mean later.

glennsarti · 2017-09-14T21:38:16Z

Fixed the travis issue. It was parallel:spec just completely blowing up on a simple bug in the spec file.

MosesMendoza · 2017-10-16T23:40:21Z

@glennsarti is this PR still actively in progress?

glennsarti · 2017-10-16T23:43:36Z

@MosesMendoza Yes. PuppetConf took precedence.

Iristyle · 2017-11-20T19:20:27Z

lib/puppet/util/windows/taskscheduler2.rb

+
+  # DONE
+  def activate(task)
+    raise Error.new(_('No current task scheduler. Schedule.Service is NULL.')) if @task_service.nil?


@task_service doesn't need nil checks in here anywhere given its assigned in the initializer and never reset.

Do we know if task has to have a leading \, or can it be a bare string?

Iristyle · 2017-11-20T19:30:05Z

lib/puppet/util/windows/taskscheduler2.rb

+  end
+
+  # DONE
+  def deactivate()


This is being used currently by the shim taskscheduler2_v1task.rb ... but perhaps activate should take an optional parameter specifying the requested compatibility level?

Iristyle · 2017-11-20T19:30:33Z

lib/puppet/util/windows/taskscheduler2_v1task.rb

+
+    full_taskname = Puppet::Util::Windows::TaskScheduler2::ROOT_FOLDER + validate_task_name(task_name)
+
+    result = @task.activate(full_taskname)


Perhaps activate should take an optional parameter specifying the requested compatibility level? Then no extra clean up is necessary and deactivate method can disappear.

Iristyle · 2017-11-20T19:41:35Z

lib/puppet/util/windows/taskscheduler2.rb

+  end
+
+  # DONE
+  def definition()


I think we believe that we will never ask for a task without also asking for its definition? Therefore, we can probably either remove this method, or change it so that it simply returns @pITaskDefinition (in the event its a public method used by other classes).

That would mean that activate is also responsible for creating the definition AND that all the below nil checks on the definition are no longer necessary.

Iristyle · 2017-11-20T20:00:22Z

lib/puppet/util/windows/taskscheduler2.rb

+      result = task_folder.DeleteTask(get_task_name_from_task(task),0)
+    rescue WIN32OLERuntimeError => e
+      # TODO win32ole errors are horrible.  Assume the task doesn't exist so deletion is successful
+      return true


For all the methods here, not sure that we should eat the WIN32OLERuntimeError. In the prior implementation, nearly all COM errors end up calling raise. The com.rb file has a helper that automatically turns failed HRESULTs into exceptions.

https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/com.rb#L140-L143

In the original v1, there are a few cases where well known HRESULTs are ignored during certain circumstances... whether they should be here or not remains to be seen.

Iristyle · 2017-11-20T20:01:40Z

lib/puppet/util/windows/taskscheduler2.rb

+  # Saves the current task. Tasks must be saved before they can be activated.
+  #
+  # DONE
+  def save()


Something to think about for a future commit / iteration of the API - do we want to pass in the definition and/or the task?

Iristyle · 2017-11-20T20:02:27Z

lib/puppet/util/windows/taskscheduler2.rb

+  def set_principal(user, password)
+    raise Error.new(_('No currently active task. ITask is NULL.')) if definition.nil?
+
+    if (user.nil? || user == "") && (password.nil? || password == "")


user.empty? instead of user == ""

Iristyle · 2017-11-20T20:05:15Z

lib/puppet/util/windows/taskscheduler2.rb

+      definition.Principal.RunLevel = TASK_RUNLEVEL_HIGHEST
+      return true
+    else
+      # TODO!!!


Looks like some work to do here.. wonder if it uses SCHED_E_ACCOUNT_INFORMATION_NOT_SET the same way as set_account_information does in the old version?

Iristyle · 2017-11-20T20:06:27Z

lib/puppet/util/windows/taskscheduler2.rb

+  # Sets the compatibility with the task.
+  # https://msdn.microsoft.com/en-us/library/windows/desktop/aa381846(v=vs.85).aspx
+  #
+  def compatibility=(value)


Might not need this just yet? Also seems like an unsafe operation?

Could this be used by Puppet users to migrate their v1 managed tasks to v2?

Iristyle · 2017-11-20T20:07:32Z

lib/puppet/util/windows/taskscheduler2.rb

+  # https://msdn.microsoft.com/en-us/library/windows/desktop/aa383070(v=vs.85).aspx
+  #
+  # DONE
+  def priority


@glennsarti says move this to the shim

Iristyle · 2017-11-20T20:08:01Z

lib/puppet/util/windows/taskscheduler2.rb

+    value
+  end
+
+  def new_task_defintion(task_name)


Missing an i in definition

Iristyle · 2017-11-20T20:11:57Z

lib/puppet/util/windows/taskscheduler2.rb

+
+    action = nil
+
+    begin


Need to look at behavior of puppet resource to see how these come out?

May need to hide this for the moment as we build out compatibility layer? Not sure just yet.. need to do some more homework.

Unlike trigger, we're returning a COM instance of an Action object - do we want that, given this is a leaky interface?

Iristyle · 2017-11-20T20:16:49Z

lib/puppet/util/windows/taskscheduler2.rb

+  end
+
+  # DONE
+  def append_trigger(trigger_hash)


Do we want to assign a default value here as documentation that this is a hash? Or does a {} not really make sense anyhow?

Mostly just concerned with making sure it's understood that it's a Ruby hash and not a Trigger COM object.

Iristyle · 2017-11-20T20:25:17Z

lib/puppet/util/windows/taskscheduler2.rb

+    time = @pITask.NextRunTime
+
+    # The API will still return a time WAAAY in the past if there is no schedule.
+    # As this is looking forward, if the next execution is 'scheduled' in the 1900s assume


I wonder if this is the minimum OLE datetime value? https://msdn.microsoft.com/en-us/library/system.datetime.tooadate(v=vs.110).aspx

An OLE Automation date is implemented as a floating-point number whose integral component is the number of days before or after midnight, 30 December 1899, and whose fractional component represents the time on that day divided by 24. For example, midnight, 31 December 1899 is represented by 1.0; 6 A.M., 1 January 1900 is represented by 2.25; midnight, 29 December 1899 is represented by -1.0; and 6 A.M., 29 December 1899 is represented by -1.25. The base OLE Automation Date is midnight, 30 December 1899. The minimum OLE Automation date is midnight, 1 January 0100. The maximum OLE Automation Date is the same as DateTime.MaxValue, the last moment of 31 December 9999.

Iristyle · 2017-11-20T21:38:17Z

lib/puppet/util/windows/taskscheduler2.rb

+  # and nS is the number of seconds (for example, PT5M specifies 5 minutes and P1M4DT2H5M specifies one month,
+  # four days, two hours, and five minutes)
+  def time_limit_to_hash(time_limit)
+    regex = /^P((?'year'\d+)Y)?((?'month'\d+)M)?((?'day'\d+)D)?T((?'hour'\d+)H)?((?'minute'\d+)M)?((?'second'\d+)S)?$/


I believe this is ISO8601 duration format - see the standard definition at https://en.wikipedia.org/wiki/ISO_8601#Time_intervals

Ruby has some support for ISO8601, but not sure about durations https://ruby-doc.org/stdlib-2.1.1/libdoc/time/rdoc/Time.html#method-c-iso8601

Iristyle · 2017-11-20T21:54:56Z

lib/puppet/util/windows/taskscheduler2.rb

+  # will run before terminating.
+  #
+  # DONE
+  def max_run_time_as_ms


@glennsarti says this is unused in the v1 world

Iristyle · 2017-11-20T21:55:22Z

lib/puppet/util/windows/taskscheduler2.rb

+  # Sets the maximum length of time, in milliseconds, that the task can run
+  # before terminating. Returns the value you specified if successful.
+  #
+  def max_run_time=(max_run_time)


No equivalent in v1

Iristyle · 2017-11-20T21:59:24Z

lib/puppet/util/windows/taskscheduler2.rb

+  def win32ole_to_hash(win32_obj)
+    hash = {}
+
+    win32_obj.ole_get_methods.each do |method|


Need to answer the question around whether we want to do this dynamically like this... or just use the names of actual properties we care about.

Given that there are a number of arbitrary trigger types that have varying properties - see https://msdn.microsoft.com/en-us/library/windows/desktop/aa383868(v=vs.85).aspx ... this might be the best way to extract information into a Ruby hash. The only other alternative seems to be looking at the XML definition of the trigger somehow.

Iristyle · 2017-11-20T22:05:32Z

lib/puppet/util/windows/taskscheduler2.rb

+
+    hash = win32ole_to_hash(task_trigger)
+
+    hash['type_name'] = task_trigger.ole_type.name


So type_name ends up being a hint for future deserialization / hydration of an appropriate COM trigger class name.... Looking at this further, I think we only need the trigger type enum value and can remove the type_name as its the name of the actual COM class, and given we never use it to create specific instance types.

Exposed as https://msdn.microsoft.com/en-us/library/windows/desktop/aa383978(v=vs.85).aspx

Iristyle · 2017-11-20T22:11:32Z

lib/puppet/util/windows/taskscheduler2_v1task.rb

+  # constructor is the same as calling TaskScheduler.new plus
+  # TaskScheduler#new_work_item.
+  #
+  def initialize(work_item = nil, trigger = nil)


Should trigger accept an array?

Looks like original implementation in taskscheduler.rb did not... and we only found one call to Win32::TaskScheduler.new that took the trigger parameter in create and its a dummy value... so no compelling reason to change this for the moment.

Iristyle · 2017-11-20T22:22:34Z

lib/puppet/util/windows/taskscheduler2_v1task.rb

+
+  def enum()
+    array = []
+    @task.enum_task_names(Puppet::Util::Windows::TaskScheduler2::ROOT_FOLDER,


Can use map

Iristyle · 2017-11-20T22:30:42Z

lib/puppet/util/windows/taskscheduler2_v1task.rb

+  end
+
+  def save(file = nil)
+    raise NotImplementedError unless file.nil?


It looks like the existing provider implementation doesn't pass a file anyhow in flush at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/scheduled_task/win32_taskscheduler.rb#L236

This is making us wonder if pIPersistFile.Save is being called with a NULL string?? https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/taskscheduler.rb#L291-L294

Iristyle · 2017-11-20T23:01:15Z

lib/puppet/util/windows/taskscheduler2_v1task.rb

+    end
+
+    # As this class is emulating the older V1 API we only support execution actions (not email etc.)
+    return nil unless action.Type == Puppet::Util::Windows::TaskScheduler2::TASK_ACTION_EXEC


Could this method be cleaned up a bit logically?

Are v1 tasks even allowed to have a list of actions?

Iristyle · 2017-11-20T23:04:03Z

lib/puppet/util/windows/taskscheduler2_v1task.rb

+  # job should run.
+  #
+  def new_work_item(task_name, task_trigger)
+    raise TypeError unless task_trigger.is_a?(Hash)


Should we create a default exec action at the same we're creating the named task and its trigger? Might be the sensible happy-path use case?

Iristyle · 2017-11-20T23:17:04Z

lib/puppet/util/windows/taskscheduler2_v1task.rb

+  #
+  # Note - This method name is a mis-nomer. It's actually appending a newly created trigger to the trigger collection.
+  def trigger=(v1trigger)
+    append_trigger(v1trigger)


Fortunately, this method is much better at describing what is actually happening.

However, the original API of .trigger = as something that adds new triggers to the end of a running list of triggers is totally bonkers 👎 . We should fix both of those, but we can ticket that / do it later.

https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/scheduled_task/win32_taskscheduler.rb#L192-L196

Iristyle · 2017-11-20T23:18:30Z

lib/puppet/util/windows/taskscheduler2_v1task.rb

+
+  # Adds a trigger at the specified index.
+  #
+  # Note - This method name is a mis-nomer.  It's actually setting a trigger at the specified index


Roll this up in the same ticket as fixing trigger =

Maybe just remove add_trigger as it's currently unused?

Iristyle · 2017-11-20T23:20:15Z

lib/puppet/util/windows/taskscheduler2_v1task.rb

+
+    # Generate the V1 Flags integer from the task definition
+    # flags list - https://msdn.microsoft.com/en-us/library/windows/desktop/aa381283%28v=vs.85%29.aspx
+    # TODO Need to implement the rest of the flags


Yeah, these should be implemented

Iristyle · 2017-11-20T23:21:23Z

lib/puppet/util/windows/taskscheduler2_v1task.rb

+  def transform_and_validate(hash)
+    new_hash = {}
+
+    hash.each{ |key, value|


probably want to use do / end for multi-line instead of { and }

Since this looks to be a verbatim copy of Win32::TaskScheduler code, might make sense to leave it as-is ... and / or extract to shared helper. Of course, if taskscheduler.rb is being deleted, then no shared helper is necessary.

Previously Puppet used the V1 API for scheduled tasks however this has been deprecated in favor of the V2 Win32OLE objects. This commit adds a parent class which can query and modify tasks via the V2 API and adds a facade class called Puppet::Util::Windows::TaskScheduler2V1Task which is binary compatible with the older V1 class Win32::TaskScheduler. This commit also adds basic smoke tests for the V2 API for CRUD operations.

This commit adds a new non-default provider for the scheduled_task puppet type which instead uses the V2 API for scheduled tasks. As this is not the default users will need to opt in to this functionality.

This commit changes the unit tests for the scheduled_task provider by running the tests against both providers (win32_taskscheduler, the default, and taskscheduler_api2). This ensures that any behaviors are consistent in both providers. The concrete class which services each provider is refactored into the concrete_klass variable which is then used in the tests themselves.

Iristyle · 2017-11-21T01:55:41Z

Existing Puppet type API for scheduled tasks at https://puppet.com/docs/puppet/5.3/type.html#scheduledtask
Task Scheduler Scripting Object docs at https://msdn.microsoft.com/en-us/library/windows/desktop/aa383607(v=vs.85).aspx
Task Scheduler 1.0 Interfaces at https://msdn.microsoft.com/en-us/library/windows/desktop/aa383581(v=vs.85).aspx

Iristyle · 2018-01-14T17:01:47Z

This has shipped in a different form in puppetlabs/puppetlabs-scheduled_task#6

glennsarti requested a review from Iristyle September 12, 2017 23:34

Iristyle suggested changes Sep 14, 2017

View reviewed changes

glennsarti force-pushed the ticket/master/pup-7894-create-tasksched2-util branch from b1e7539 to c3ff155 Compare September 14, 2017 20:35

Iristyle reviewed Nov 20, 2017

View reviewed changes

lib/puppet/util/windows/taskscheduler2.rb

value

end

def new_task_defintion(task_name)

Copy link

Contributor

Iristyle Nov 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an i in definition

Iristyle reviewed Nov 20, 2017

View reviewed changes

glennsarti force-pushed the ticket/master/pup-7894-create-tasksched2-util branch from 3453070 to e0c544d Compare November 21, 2017 00:28

glennsarti added 3 commits November 20, 2017 16:29

(PUP-7894) Add a new provider for Scheduled Taks which uses the V2 API

3972900

This commit adds a new non-default provider for the scheduled_task puppet type which instead uses the V2 API for scheduled tasks. As this is not the default users will need to opt in to this functionality.

glennsarti force-pushed the ticket/master/pup-7894-create-tasksched2-util branch from e0c544d to 11b78a9 Compare November 21, 2017 00:30

glennsarti mentioned this pull request Nov 22, 2017

{WIP}(PUP-7894) Add Scheduled Task V2 API functionality #6382

Closed

Iristyle closed this Jan 14, 2018

		@@ -0,0 +1,707 @@
		#require 'puppet/util/windows/error'
		#require 'win32ole' # TODO should guard this on Windows only


		full_taskname = Puppet::Util::Windows::TaskScheduler2::ROOT_FOLDER + validate_task_name(task_name)

		result = @task.activate(full_taskname)


		hash = win32ole_to_hash(task_trigger)

		hash['type_name'] = task_trigger.ole_type.name

Uh oh!

{WIP}(PUP-7894) Add Scheduled Task V2 API functionality #6198

{WIP}(PUP-7894) Add Scheduled Task V2 API functionality #6198

Uh oh!

Conversation

glennsarti commented Sep 12, 2017

Uh oh!

glennsarti commented Sep 13, 2017

Uh oh!

puppetcla commented Sep 13, 2017

Uh oh!

Iristyle commented Sep 14, 2017

Uh oh!

glennsarti commented Sep 14, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

glennsarti commented Sep 14, 2017

Uh oh!

MosesMendoza commented Oct 16, 2017

Uh oh!

glennsarti commented Oct 16, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Iristyle Nov 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Iristyle Nov 20, 2017 •

edited

Loading

Iristyle Nov 20, 2017 •

edited

Loading

Iristyle Nov 20, 2017 •

edited

Loading