(MAINT) Perform pdk update #2114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was primarily done to add the following line to the Rakefile: `FastGettext.default_text_domain = 'default-text-domain'` and prevent syntax checks failing because of the text domain is not set (which generates a return code of 1).
sanfrancrisko
force-pushed
the
maint/main/fix_FastGetText
branch
from
d3634dd to
341bc2f
Compare
Codecov Report
@@ Coverage Diff @@
## main #2114 +/- ##
==========================================
- Coverage 57.40% 56.36% -1.05%
==========================================
Files 12 12
Lines 216 220 +4
==========================================
Hits 124 124
- Misses 92 96 +4
Continue to review full report at Codecov.
|
sheenaajay
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was primarily done to add the following line to the Rakefile:
FastGettext.default_text_domain = 'default-text-domain'andprevent syntax checks failing because of the text domain is not
set (which generates a return code of 1).