-
Notifications
You must be signed in to change notification settings - Fork 470
MODULES-2861: run stages limitation added to the documentation. #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to use a different word than conflict. In Puppet lingo that's normally associated with resource conflicts, and that's not the case. It doesn't really conflict in that sense, it just causes all virtual resources to be realised at that point because of the unfortunate side-effect that collectors <||> cause realisation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand.
What about:
Be aware that this example will realize all your virtual package resources. Adapt it to your environment.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍. Though this now poses the interesting question if people will understand what we mean with "realise". I think it's good enough for now though, we can clarify it further if it comes up often.
|
@daenney Not sure I did well for the git squash. |
|
@ryayon I'm seeing 4 commits now. We should be down to 1 from 2 but it multiplied so I think that went wrong 😄. |
|
@daenney I completely messed up. |
|
That's alright, as long as we get the intended end result. Thank you! |
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to restrict this to apt packages only? Otherwise other providers such as gems would be affected.
Class['apt::update'] -> Package <| provider == 'apt' |>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you, but the way you realize the resource means that you have to specifically provide the parameter provider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow. Using the spaceship collector without specifying the provide will collect all package resources in the catalogue, which you probably don't need to do, as it will collect gems, npm packages etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean,
- if you are on a Debian-like OS, by default, Puppet will use apt to manage packages.
- if you specify provider=apt, it will also use apt to manage packages.
Once you use:
Package <| provider == 'apt' |>
, will it realize all resources or only the 2nd case resources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I understand what you're saying now 👍
99% sure it's 2, as I've done this with yum_repo resources before, but I can check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to check also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's 2, so that's the correct change 👍
|
I'm 👍 on the language. |
|
Alright. Then I'll wait on the change that @petems has suggested and merge it. |
|
Done |
|
I feel that this has gone wrong: Now we have two examples with different collectors. |
|
Indeed, I didn't see that. and update the current |
|
Sounds good to me. |
|
Pushed again. |
MODULES-2861: run stages limitation added to the documentation.
|
Off it goes. Thank you for the work! |
|
Sounds good. |
No description provided.