(MODULES-5844) Move all code to dsc_lite namespace #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Additionally remove references to both stdlib and powershell modules as dependencies. The LCM config manifest wsa the only thing using these modules, and without it, they can be removed!
- Remove all the generated types from lib/puppet/type/dsc_* and their
corresponding specs from spec/unit/puppet/type/dsc_*.
- Remove all vendored content inside of lib/puppet_x/dsc_resources/,
except for xService in xPSDesiredStateConfiguration. xService is
used in an acceptance test that may need to have a more generic
equivalent built.
- Remove most acceptance tests on basic dsc resources that won't be
part of this module any longer from tests/acceptance/tests/,
tests/integration/tests/ and corresponding test fixture data from
tests/files/test_installer/ and tests/manifests/.
More generic tests that use dsc_file were left (for now).
- Exceptions:
* Leave dsc_file.rb type for now to allow specs to pass.
* Leave dsc_service.rb and dsc_xservice.rb to allow acceptance
tests to pass.
- This commit updates the changelog, metadata.json and other misc files. Metadata update to reflect the new module name, resets the version back to 0.1.0 and removes all prior versions of the dsc module from the changelog.
This commit moves the PowerShellManager class and dependent files from the `dsc` namespace to the `dsc_lite` namespace. Where it was possible, template files were moved closer to the classes that used them. In all cases a namespace was added to all types and classes to differentiate the new module from any prior dsc module installs. Changes include: * Ruby PuppetX::Dsc -> PuppetX::DscLite * Ruby PuppetX::PuppetLabs::Dsc -> PuppetX::PuppetLabs::DscLite * renaming Puppet type base_dsc -> base_dcslite * using a dsc_lite path to namespace in the filesystem * updating existing wrappers (like the fake resource) to use the new names and paths
- Move into the same directory as the provider code given there is no need for a separate templates directory, and given the prior path would conflict with the existing module.
This was referenced Nov 15, 2017
Iristyle
commented
Nov 17, 2017
| @@ -1,10 +1,10 @@ | |||
| require 'pathname' | |||
| require Pathname.new(__FILE__).dirname + '../' + 'puppet_x/puppetlabs/powershell_version' | |||
| require Pathname.new(__FILE__).dirname + '../' + 'puppet_x/puppetlabs/dsc_lite/powershell_version' | |||
Contributor
Author
There was a problem hiding this comment.
Note that powershell_version still conflicts on a filename and fact name basis with all the other modules that do this - powershell, dsc and iis (so far). Fortunately we haven't been bit by this given all these modules implement the fact the same way, but something to think about for another day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #3, which has now been reduced to removing nearly all vendored content / acceptance tests
This commit moves the PowerShellManager class and dependent files from
the
dscnamespace to thedsc_litenamespace. Where it was possible,template files were moved closer to the classes that used them. In all
cases a namespace was added to all types and classes to differentiate
the new module from any prior dsc module installs. Changes include:
new names and paths