(MODULES-5842) WIP dsc type and invoker #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iristyle
commented
Nov 21, 2017
| @param_hash = resource | ||
| template = ERB.new(File.new(template_path + "/invoke_dsc_resource.ps1.erb").read, nil, '-') | ||
| # TODO: double-check that 'type' is the right thing to check | ||
| template_name = resource.type == 'dsc' ? |
Contributor
Author
There was a problem hiding this comment.
Uses the type to figure out which template to load.
Contributor
Author
|
Work is continuing in #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jpogran here's what you were doing in #2, rebased on top of everything that was merged.
I only made the one change we had been talking about - using a new ERB template for the generic resource invocation. Feel free to grab this commit into your PR / close this PR.