Added Factfile as a parameter and in dockerfile #14
Conversation
sheenaajay
left a comment
sheenaajay
left a comment
There was a problem hiding this comment.
@jonnaladheeraj .Thanks for the contribution.
Please incorporate the mInor comments.
| @context[:use_factfile] = true | ||
| end | ||
| end | ||
| def determine_if_using_hiera |
There was a problem hiding this comment.
Add a new line after the function determine_if_using_factfile
There was a problem hiding this comment.
I have added a new line after the function and made sure end is aligned with the function def
| <% end %> | ||
|
|
||
| <% if use_factfile %> | ||
| COPY <%= factfile %> /etc/puppetlabs/facter/facts.d/custom_facts.txt |
There was a problem hiding this comment.
Just wondering if we should give an option to the user where to copy the files
/opt/puppetlabs/facter/facts.d/
/etc/puppetlabs/facter/facts.d/
/etc/facter/facts.d/
There was a problem hiding this comment.
Wanted all the facts to be at a location that are passed as a parameter. I can change it and ask user to enter the path for creation/checking facts.d folder and adding the facts file into it
|
@jonnaladheeraj Thanks for the prompt reply.I committed some fixes for the travis CI build error.Could you please rebase them your branch to verify if travis CI build is passing. |
|
Travis erros are fixed and restarted the build succcesfully |
3 participants
Adding Factfile as a parameter when connected to puppet master it determines which modules needs to be installed depending on the facts file supplied as a parameter.