This repository was archived by the owner on Oct 30, 2019. It is now read-only.
(CLOUD-826) Agent upgrade #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheenaajay
force-pushed
the
image_build_agent_upgrade
branch
from
39bca91 to
9159a08
Compare
Contributor
|
@sheenaajay looks like a new version of rubocop has some new opinions and is blocking the test suite. If you could fix up in a separate commit in this PR. |
sheenaajay
force-pushed
the
image_build_agent_upgrade
branch
from
9159a08 to
b4c08c6
Compare
Contributor
Author
|
@gareth...fixed the ordering in the Gem file and just pushed the changes. 29 files inspected, no offenses detected 29 files inspected, no offenses detected Hopefully it should pass now.. Seeing coverage error now ..oops |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imagebuilder.rb and imagebuilder_face.rb are modified for agent upgrade