This repository was archived by the owner on Oct 30, 2019. It is now read-only.
Check return code of puppet apply. #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the docker build succeeds even if puppet apply does not succeed. Puppet apply has a non-standrad system of return codes. It will return 0 even if it hasn't sucessfully applied the manifest unless `--detailed-exitcodes` is given. When this is given if it returns 0 or 2 the manifest has been applied sucessfully [0]. This patch makes the docker build fail if the manifest is not applied successfully. [0] https://docs.puppet.com/puppet/latest/man/apply.html#OPTIONS
Contributor
|
@oc243 thanks, nice fix. I've just tried this out locally and it works for me. Appreciated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the docker build succeeds even if puppet apply does not
succeed.
Puppet apply has a non-standrad system of return codes. It will
return 0 even if it hasn't sucessfully applied the manifest unless
--detailed-exitcodesis given. When this is given if it returns0 or 2 the manifest has been applied sucessfully [0].
This patch makes the docker build fail if the manifest is not
applied successfully.
[0] https://docs.puppet.com/puppet/latest/man/apply.html#OPTIONS