This repository was archived by the owner on Oct 30, 2019. It is now read-only.
adding volume #35
Merged
adding volume #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethr
suggested changes
Mar 3, 2017
Contributor
garethr
left a comment
garethr
left a comment
There was a problem hiding this comment.
Hi @luckyraul. The code for this looks good. At the moment the tests are failing as the assertions are against the wrong context attributes, but that should just be a matter of fixing the wording indicated in the comments. Thanks for adding too.
| volume: '/var/www', | ||
| } | ||
| end | ||
| it 'should expand the port to an array' do |
Contributor
There was a problem hiding this comment.
This should refer to the volume rather than the port
| } | ||
| end | ||
| it 'should expand the port to an array' do | ||
| expect(context).to include(expose: ['/var/www']) |
Contributor
There was a problem hiding this comment.
This should make an assertion against the volume attribute rather than expose
| volume: '/var/www,/var/lib', | ||
| } | ||
| end | ||
| it 'should expand the labels to an array' do |
Contributor
There was a problem hiding this comment.
This should refer to volume rather than the labels
| } | ||
| end | ||
| it 'should expand the labels to an array' do | ||
| expect(context[:expose]).to include('/var/www','/var/lib') |
Contributor
There was a problem hiding this comment.
As above this should refer to volume rather than expose
garethr
approved these changes
Mar 5, 2017
Contributor
|
@luckyraul neat addition. Thanks again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.