Newly created store is of type PKCS12, even when storetype is JKS

[ricoapon]

Describe the Bug

Whenever a new store is created, a command is executed to create a new store. If you specify, JKS as storetype, you still get PKCS12 as type.

Expected Behavior

The store type is JKS.

Steps to Reproduce

1, Create the following configuration:

java_ks { 'some_alias':
        ensure              => latest,
        target              => '/some_path',
        password            => 'some_password',
        certificate_content => '...'
        storetype           => 'jks'
      }

2. Run puppet and make sure the store does not exist yet.

Environment

• Java_ks version 4.3.1
• Puppet version 6.27.0
• Linux RHEL 7

Additional Context

I found the issue in the code. See keytool.rb function def create. Based on the storetype different code is executed. The else case is done when storetype is jks, but no storetype is set in this command. Adding it would solve the issue.

[pmcmaw]

Duplicated issue with additional information exists here: https://tickets.puppetlabs.com/browse/MODULES-10568

[pmcmaw]

Closing in favour of tracking in JIRA.

[juliantaylor]

the jira issue says it should be closed for tracking in github, where are you tracking?

[pmcmaw]

Hey @juliantaylor I have removed that comment stating it should be tracked in github.

In line with company preferences, we will be tracking in JIRA under a project called CONT (Content&Tooling)
I have moved the JIRA ticket above into this new project and labelled with Customer-Support: https://tickets.puppetlabs.com/browse/CONT-186

If you click on the old issue (https://tickets.puppetlabs.com/browse/MODULES-10568) it will automatically take you to the issue.

Apologies for the confusion, we are currently trying to bring everything inline.

[ArcticSnowman]

Is there a reason these JIRA tickets are no publicly visible

[ArcticSnowman]

The code change frim CONT-186 only dealt with when both a private key and cert are imported, it forgot to deal with when it's just a CERT being added for a truststore.

@david22swan - https://github.com/puppetlabs/puppetlabs-java_ks/blob/main/lib/puppet/provider/java_ks/keytool.rb#L249-L260 this needs fixing too.

      cmd = [
        command_keytool,
        '-importcert', '-noprompt',
        '-alias', @resource[:name],
        '-file', certificate,
        '-keystore', @resource[:target]
      ]
      cmd << '-trustcacerts' if @resource[:trustcacerts] == :true
      tmpfile = password_file
      run_command(cmd, @resource[:target], tmpfile)
      tmpfile.close!

Adding this maybe

    cmd += ['-storetype', storetype] unless storetype.nil?