Make it possible to omit the file system type for lmv::volume #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though one would probably want to omit the file system type more often than the size, I didn't dare to change the order of the parameters in order to preserve backwards compatibility
hunner
pushed a commit
that referenced
this pull request
Sep 28, 2016
* Add support for thin provisioning and setting poolmetadatasize * Additional fixes and testing/docs This commit fixes the comments raised in PR/154 and adds testing and documentation; * Inherit the thin attribute from Puppet::Parameter::Boolean * Conditionally add -n flag to provider args rather than drop later * Fixed hard tab spaces in provider * Added documentation for new attributes * Added rspec tests * added thin and poolmetadatasize to lvm::volume_group defined type * Changed thin attribute to thinpool * changed error message for poolmetadatasize validation * Document that poolmetadatasize currently only sets on creation * changed $thin to $thinpool, ommitted after attribute rename (#3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though one would probably want to omit the file system type more
often than the size, I didn't dare to change the order of the parameters
in order to preserve backwards compatibility