Skip to content

Remove trailing commas for Puppet 2.7.1 compatibility #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2012

Conversation

jarib
Copy link
Contributor

@jarib jarib commented Aug 25, 2012

Thanks for creating this module!

I had to remove a few trailing commas to make things run on 2.7.1 (which is the default in Ubuntu 11.10).

This makes the module work on Puppet 2.7.1 (from Ubuntu 11.10).
@kennknowles
Copy link
Contributor

Merging even though I love trailing commas :-)

For reference, support for trailing commas in argument lists was added in Puppet 2.7.8, released 2011-12-08.
(release notes) (ticket)

kennknowles added a commit that referenced this pull request Aug 29, 2012
Remove trailing commas for Puppet 2.7.1 compatibility
@kennknowles kennknowles merged commit e7bb659 into puppetlabs:master Aug 29, 2012
@jarib
Copy link
Contributor Author

jarib commented Aug 29, 2012

Thanks! Turns out there are other issues on Ubuntu 11.10 as well. I had to add a few symlinks to make things run:

/etc/postgresql/main -> /etc/postgresql/9.1/main
/usr/lib/postgresql/{bin,lib} -> /usr/lib/postgresql/9.1/{bin,lib}

It's not an issue for me personally as we'll upgrade to Ubuntu 12 soon anyway, so if you don't want to support 11.10 (and revert this), that's cool.

hunner added a commit to hunner/puppetlabs-postgresql that referenced this pull request Jan 14, 2014
(PE-2539) Add containment for external consumers
apenney pushed a commit that referenced this pull request May 13, 2014
'!' binds before 'and'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants