(MODULES-8748) Add OSX testing

Previously Travis CI only tested linux.  This commit adds a single cell of OSX
testing to ensure that the PowerShell manager can communicate correctly with
a PowerShell Core Pipe Server.  This is required due to Unix Domain Sockets
behaving differently on OSX as compared to Linux (Ubuntu Trusty).

Author: glennsarti

.travis.yml

@@ -1,13 +1,31 @@
 ---
+os:
+  - linux
+  # OSX Only tests on the latest Puppet Gem, not the full matrix as there's no need to double up
+  # testing effort here. We are only concerned about whether the Mac OSX edition of PowerShell Core
+  # will work with our PowerShell manager code.
+  - osx
+
 dist: trusty
 language: ruby
 cache: bundler
 before_install:
   # Additional instructions
-  - curl https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add -
-  - curl https://packages.microsoft.com/config/ubuntu/14.04/prod.list | sudo tee /etc/apt/sources.list.d/microsoft.list
-  - sudo apt-get update
-  - sudo apt-get install -y powershell
+  # Install PowerShell Core for Ubuntu 14.04
+  # There's an intermittent minor issue with the public key so just reset it with apt-key ... - https://github.com/git-lfs/git-lfs/issues/3474
+  - if [ $TRAVIS_OS_NAME == "linux" ]; then
+      curl https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add -;
+      curl https://packages.microsoft.com/config/ubuntu/14.04/prod.list | sudo tee /etc/apt/sources.list.d/microsoft.list;
+      sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 6B05F25D762E3157;
+      sudo apt-get update;
+      sudo apt-get install -y powershell;
+    fi
+  # Install PowerShell Core for Mac
+  - if [ $TRAVIS_OS_NAME == "osx" ]; then
+      brew cask install powershell;
+    fi
+  # Output the PowerShell Core version information
+  - pwsh -NoProfile -NoLogo -NonInteractive -Command \$PSVersionTable
   - if [ $BUNDLER_VERSION ]; then
       gem install -v $BUNDLER_VERSION bundler --no-rdoc --no-ri;
     fi
@@ -24,18 +42,17 @@ rvm:
 env:
   global:
     - BEAKER_PUPPET_COLLECTION=puppet6 PUPPET_GEM_VERSION="~> 6.0"
+    - CHECK=parallel_spec
 matrix:
   fast_finish: true
   include:
     -
       env: CHECK="syntax lint metadata_lint check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop"
     -
-      env: CHECK=parallel_spec
-    -
-      env: PUPPET_GEM_VERSION="~> 5.0" CHECK=parallel_spec
+      env: PUPPET_GEM_VERSION="~> 5.0"
       rvm: 2.4.4
     -
-      env: PUPPET_GEM_VERSION="~> 4.0" CHECK=parallel_spec RUBYGEMS_VERSION=2.7.8 BUNDLER_VERSION=1.17.3
+      env: PUPPET_GEM_VERSION="~> 4.0" RUBYGEMS_VERSION=2.7.8 BUNDLER_VERSION=1.17.3
       rvm: 2.1.9
 branches:
   only:

spec/integration/puppet_x/puppetlabs/powershell_manager_spec.rb

@@ -42,6 +42,11 @@ def line_end
     Puppet::Util::Platform.windows? ? "\r\n" : "\n"
   end
 
+  def is_osx?
+     # Note this test fails if running in JRuby, but because the unit tests are MRI only, this is ok
+    !RUBY_PLATFORM.match(/darwin/).nil?
+  end
+
   let (:manager) { create_manager(ps_command, ps_args) }
 
   describe "when managing the powershell process" do
@@ -325,6 +330,9 @@ def close_stream(stream, style = :inprocess)
       expect(result[:stdout]).to eq(nil)
       if Puppet::Util::Platform.windows?
         expect(result[:stderr]).to eq(["'foo.exe' is not recognized as an internal or external command,\r\noperable program or batch file.\r\n"])
+      elsif is_osx?
+        expect(result[:stderr][0]).to match(/foo\.exe: command not found/)
+        expect(result[:stderr][0]).to match(/bar/)
       else
         expect(result[:stderr][0]).to match(/foo\.exe: not found/)
         expect(result[:stderr][0]).to match(/bar/)