Fix autorequiring when using different root key forms #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, autorequiring would not add relationships when resources mix short and long forms of the root key, e.g. hklm and hkey_local_machine. It also did not handle different cases, hklm vs HKLM. This commit ensures that we always create a canonical path for the `KeyPath` and `ValuePath`, which always use the downcased root key name. In the process, the ascend logic was greatly simplified. This commit does not fix general case-insensitivity in key and value names, e.g. so hklm\Software and hklm\software are still seen as different resources. This will be addressed in a separate commit.
jeffmccune
pushed a commit
that referenced
this pull request
Apr 21, 2012
Fix autorequiring when using different root key forms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, autorequiring would not add relationships when resources mix
short and long forms of the root key, e.g. hklm and hkey_local_machine. It
also did not handle different cases, hklm vs HKLM.
This commit ensures that we always create a canonical path for the
KeyPathandValuePath, which always use the downcased root key name.In the process, the ascend logic was greatly simplified.
This commit does not fix general case-insensitivity in key and value
names, e.g. so hklm\Software and hklm\software are still seen as different
resources. This will be addressed in a separate commit.