(PE-13485) Implement a consistent request logging format #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit puppetserver used a different request logging format than puppetdb and console-services. After this commit the request logging will be of the suggested formatting for all trapper-keeper projects.
Contributor
|
👍 It seems a bit concerning that we merged #886 but it isn't in any of our branches... it looks like we last merged up 2.1.x in December, but this was merged in January, and then we deleted that branch in March.... |
Author
|
@rlinehan thx; when this gets merged I will try to do some merge-ups across all the branches, and will look into the 2.1.x thing as part of that. |
Contributor
|
👍 Looks like the prior PR did, so I assume it's good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit puppetserver used a different request
logging format than puppetdb and console-services.
After this commit the request logging will be of the suggested
formatting for all trapper-keeper projects.