Ensure FacterImpl consistency between example groups #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
added a commit
to voxpupuli/puppet-bird
that referenced
this pull request
Dec 6, 2021
|
I tested this on the borg module and it works fine: voxpupuli/puppet-bird#87 |
ekohl
reviewed
Dec 6, 2021
Using the 'rspec' facter implementation we could sometimes get in a case where the values of FacterImpl and Puppet.runtime[:facter] diverged between example groups. Because rspec-puppet overrides facts using the FacterImpl constant (which is only set once), Puppet.runtime[:facter] would point to a different instance of FacterTestImpl with no available facts, causing calls to Puppet.runtime[:facter].value to fail. To prevent this from happening, set Puppet.runtime[:facter] to the value of FacterImpl; this way we make sure Puppet.runtime[:facter] and FacterImpl operate on the same instance of FacterTestImpl.
GabrielNagy
force-pushed
the
facter-impl-consistency
branch
from
fdab041 to
a346ced
Compare
|
I restarted the CI in voxpupuli/puppet-bird#87 and the unit tests passed again. |
ekohl
reviewed
Dec 6, 2021
ekohl
approved these changes
Dec 6, 2021
GabrielNagy
force-pushed
the
facter-impl-consistency
branch
from
436340a to
614347f
Compare
bastelfreak
approved these changes
Dec 7, 2021
|
@ciprianbadescu would it be possible to release this soonish? (this blocks a few Vox Pupuli pipelines) |
|
@bastelfreak 2.11.1 should be out now! |
|
Hello folks! I saw similar errors into 2 VoxPupuli PRs, voxpupuli/puppet-mongodb#633 and voxpupuli/puppet-windows_firewall#124 Do you think that's still related to this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the 'rspec' facter implementation we could sometimes get in a case where the values of
FacterImplandPuppet.runtime[:facter]diverged between example groups.Because rspec-puppet overrides facts using the
FacterImplconstant (which is only set once),Puppet.runtime[:facter]would point to a different instance ofFacterTestImplwith no available facts, causing calls toPuppet.runtime[:facter].valueto fail.To prevent this from happening, attempt to set
Puppet.runtime[:facter]to the value ofFacterImplif available, this way we make surePuppet.runtime[:facter]andFacterImploperate on the same instance ofFacterTestImpl.