Add initial CI config #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@f-f any idea what's up with the build? |
|
@anttih the CI is not happy because it's trying to feed to the compiler JS modules that are not ES modules, and the compiler rejects those. I believe this is because we have based this implementation on the previous major version of the library (5.x), and we should rebase all of our commits on the latest commit from upstream. |
f-f
reviewed
Sep 23, 2023
.github/workflows/ci.yml
Outdated
| sudo apt install chezscheme | ||
| - name: Setup PureScript dependencies | ||
| run: npm i --global purescript@0.15.10 purs-tidy@latest spago@next purescript-psa@latest purescm@next |
There was a problem hiding this comment.
Spago includes PSA now:
Suggested change
| run: npm i --global purescript@0.15.10 purs-tidy@latest spago@next purescript-psa@latest purescm@next | |
| run: npm i --global purescript@0.15.10 purs-tidy@latest spago@next purescm@next |
package.json
Outdated
| "build": "eslint src && pulp build -- --censor-lib --strict", | ||
| "test": "pulp test" | ||
| "build": "spago build", | ||
| "test": "spago build && purescm bundle-app --main Test.Main && scheme --program output/main" |
There was a problem hiding this comment.
Just a thought: we might want to add a test command to purescm, that does the bundle-app + call to scheme
package.json
Outdated
| "purescript-psa": "^0.8.0", | ||
| "pulp": "^15.0.0", | ||
| "rimraf": "^3.0.2" | ||
| "purescm": "1.0.0" |
There was a problem hiding this comment.
I don't think we need this line if we are relying on a global install
f-f
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CI configuration that runs the test suite using the npm package
purescm.