Skip to content

Remove primes from foreign modules exports #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Remove primes from foreign modules exports #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/React/Basic/DOM.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

const ReactDOM = require("react-dom");

exports["render'"] = (jsx) => (node) => (callback) => () =>
exports.renderThen = (jsx) => (node) => (callback) => () =>
ReactDOM.render(jsx, node, callback);

exports["hydrate'"] = (jsx) => (node) => (callback) => () =>
exports.hydrateThen = (jsx) => (node) => (callback) => () =>
ReactDOM.hydrate(jsx, node, callback);

exports.unmount = (node) => () => ReactDOM.unmountComponentAtNode(node);
Expand Down
10 changes: 8 additions & 2 deletions src/React/Basic/DOM.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ render jsx node = render' jsx node (pure unit)
-- | DOM update is complete.
-- |
-- | __*Note:* Relies on `ReactDOM.render`__
foreign import render' :: JSX -> Element -> Effect Unit -> Effect Unit
render' :: JSX -> Element -> Effect Unit -> Effect Unit
render' = renderThen

foreign import renderThen :: JSX -> Element -> Effect Unit -> Effect Unit

-- | Render or update/re-render a component tree into
-- | a DOM element, attempting to reuse the existing
Expand All @@ -56,7 +59,10 @@ hydrate jsx node = hydrate' jsx node (pure unit)
-- | __*Note:* Relies on `ReactDOM.hydrate`, generally only
-- | used with `ReactDOMServer.renderToNodeStream` or
-- | `ReactDOMServer.renderToString`__
foreign import hydrate' :: JSX -> Element -> Effect Unit -> Effect Unit
hydrate' :: JSX -> Element -> Effect Unit -> Effect Unit
hydrate' = hydrateThen

foreign import hydrateThen :: JSX -> Element -> Effect Unit -> Effect Unit

-- | Attempt to unmount and clean up the React app
-- | rendered into the given element. Returns `true`
Expand Down