Add getter and setter for TextAlign property #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
oops, I'll fix those conflicts, one sec. |
Member
|
Looks like this one is unmergeable after applying the other two, could you update it please? Could do the export hiding at the same time too. :) |
Member
There was a problem hiding this comment.
Since this is unsafe you could do it as a partial function with a pattern match anyway:
unsafeParseTextAlign "left" = AlignLeft
unsafeParseTextAlign "right" = AlignRight
...
Collaborator
Author
There was a problem hiding this comment.
oh yeah, of course, cheers :) Now I'm struggling to work out why I initially decided that I needed the ffi there...
Merged
Collaborator
Author
|
Superseded by #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested
textAlignandsetTextAlignon firefox 33.