Various future proofing updates #17
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make compatible with unreleased version of web-dom https://github.com/purescript-web/purescript-web-dom/tree/326c125d2f9dd5c5c1e74ac17fb95d5ddd7b4450 * fix missing import in test/Main.purs * moved from bower/psc-package to spago/registry * deleted test js and html. Because the js was doing a ES6 module import while not being used as a module itself. When used as module (for example with <script type="module" src="./index.js"></script>) CORS restrictions come into play. This should either be done with a local development server or a shim like jsdom to test it with nodejs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is usable as is, specifically for working with the upcoming version of web-dom
however i recommend to not merge it now and let it stay in draft at least until the new web-dom version is out. And secondly it would be nice to make the test runnable in the browser or nodejs.