Skip to content

Update to v0.14.0-rc3 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Update to v0.14.0-rc3 #43

wants to merge 5 commits into from

Conversation

@JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Dec 8, 2020 •
edited
Loading

@JordanMartinez
Copy link
Contributor Author

JordanMartinez commented Dec 8, 2020

CI fails with this error:

> eslint src && spago build --purs-args '--censor-lib --strict'


/home/runner/work/purescript-web-html/purescript-web-html/src/Web/HTML.js
Error:   1:11  error  'window' is already defined as a built-in global variable  no-redeclare

/home/runner/work/purescript-web-html/purescript-web-html/src/Web/HTML/HTMLImageElement.js
Error:   1:11  error  'Image' is already defined as a built-in global variable  no-redeclare

✖ 2 problems (2 errors, 0 warnings)

@kl0tl
Copy link
Contributor

kl0tl commented Dec 8, 2020

This happens because of the /* global window */ and /* global Image */ comments in src/Web/HTML.js and src/Web/HTML/HTMLImageElement.js. We can remove them.

kl0tl
kl0tl reviewed Dec 8, 2020
View reviewed changes
spago.dhall Outdated
Comment on lines 1 to 4
{-
Welcome to a Spago project!
You can edit this file as you like.
-}
Copy link
Contributor

@kl0tl kl0tl Dec 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we remove this comment?

Copy link
Contributor Author

@JordanMartinez JordanMartinez Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'm actually wondering why that comment still exists. I think I'll open an issue.

@JordanMartinez JordanMartinez deleted the updateTo14 branch December 10, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kl0tl kl0tl kl0tl approved these changes

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JordanMartinez @kl0tl @thomashoneyman